Review main Abandoned

25063[BUGFIX] Don't apply optionSplit to noTrimWrap

Stefan Froemken CR 0 V 0 Easy +1 −1 updated 09/23/14, 08:31

Commit message

optionSplit searches for parts like || and |*|
noTrimWrap contains these parts very often
So it's better to exclude noTrimWrap from optionSplit

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 5

  1. Mr. Jenkins commented on patch set 1 10/30/13, 08:02

  2. Dmitry Dulepov commented on patch set 1 CR -2 10/30/13, 11:23

    Breaks compatibility in TYPO3 6.x. Also there is a way to use another character for optionSplit since TYPO3 6.1 (see TSRef).
  3. Sascha Egerer commented on patch set 1 CR -1 10/30/13, 13:00

    As Dmitry already said: use splitChar to "fix" that.
  4. Jigal van Hemert commented on patch set 1 CR -2 10/30/13, 13:03

    removing optionSplit or noTrimWrap is even worse. As Dmitry mentioned, noTrimWrap has a .splitChar property in recent versions to solve the confusion of the meaning of || or |*| This is documented in the TypoScript reference for noTrimWrap.
  5. Markus Klein abandoned the change 09/23/14, 08:31

    Forge ticket has been closed.