Review main Abandoned

25065[BUGFIX] clear locks directory on clear all Cache

Stefan Froemken CR 0 V 0 Easy +4 −0 updated 03/27/14, 09:59

Commit message

If a request breaks the locks directory was not
cleared. So next request needs nearly 30 seconds
to show FE again.
Because this only happens while development it
would be good to clear this directory on clear all
cache cmd

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 8

  1. Mr. Jenkins commented on patch set 1 10/30/13, 09:23

  2. Dmitry Dulepov commented on patch set 1 10/30/13, 11:20

    Since it is development only, your friend is shell with 'find typo3temp/locks -type f -delete'. On production if there are many requests, this may cause collisions. I would not be in favour of such change.
  3. Stefan Neufeind commented on patch set 1 CR -1 10/30/13, 13:54

    I agree with Dmitry that this approach might cause us trouble in other areas.
  4. Stefan Neufeind commented on patch set 1 10/30/13, 13:55

    Can we maybe clear the according locks of this instance inside DebugErrorHandler (which outputs formatted exceptions etc.)?
  5. Stefan Neufeind commented on patch set 1 02/24/14, 23:19

    How could we proceed here?
  6. Markus Klein commented on patch set 1 CR -1 02/25/14, 12:16

    This is only half of the story and I agree with Stefan and Dmitry. These files are only created if locking is set to flock or simple. On a properly configured unix system, one would use semaphore locking anyway. Then you shouldn't have troubles with orphaned files.
  7. Markus Klein commented on patch set 1 03/26/14, 21:53

    Please abandon this patch. DataHandler should not handle cache internal stuff.
  8. Stefan Froemken abandoned the change 03/27/14, 09:59

    As discussed: This patch should not be part of TYPO3.