Review main Merged

2507[FEATURE][INSTALL] Check MySQL privileges to create new databases

Steffen Gebert CR +2 V +2 Normal +102 −5 updated 06/03/13, 20:49

Commit message

Hide the option to create a new MySQL database within the 1-2-3 wizard,
if the MySQL user has no permissions to do so.

Review

  • Code review CR +2
    • Andreas Wolf +2
  • Verified V +2
    • Andreas Wolf +2

Issues 1

Files 3

Review log 37

Show 12 earlier messages
  1. Andreas Wolf commented on patch set 1 10/26/11, 14:36

    Verified; I would prefer that you didn't submit this I think it is too harsh to remove the create database option altogether if a user does not have the neccessary rights to create a database with an arbitrary name. E.g. I usually have a user typo3 on my test installations that has all privileges (except GRANT) for all databases starting with typo3.
  2. Andreas Wolf uploaded patch set 2 10/26/11, 14:36

  3. Andreas Wolf commented on patch set 3 10/26/11, 14:36

    The first patchset had a serious issue: Only the first found grant pattern was used for checking because the output of sql_fetch_assoc() was used for iterating over it. I also added a check for patterns that the user may have grant permissions on (e.g. something%). These patterns are then displayed, together with databases that the user may create and that currently don't exist.
  4. Andreas Wolf uploaded patch set 3 10/26/11, 14:36

  5. Andreas Wolf uploaded patch set 4 10/26/11, 14:36

  6. Andreas Wolf commented on patch set 4 10/26/11, 14:36

    Fixed the issues raised by Georg and also adjusted the styling a little to get rid of the notice wrapping around because the text made it get too wide.
  7. Björn Pedersen commented on patch set 1 10/26/11, 14:36

    Looks good to me, but someone else must approve
  8. Stefan Neufeind voted on patch set 1 V 0 10/26/11, 14:36

  9. Stefan Neufeind commented on patch set 1 10/26/11, 14:36

    Looks good to me, but someone else must approve
  10. Stefan Neufeind commented on patch set 4 10/26/11, 14:36

    Reminder
  11. Stefan Neufeind commented on patch set 4 10/26/11, 14:36

    Looks good to me, but someone else must approve didn't verify (test) it again. but changes look reasonable against what I last tested successfully
  12. Andreas Wolf commented on patch set 5 V 0 10/26/11, 14:36

    by team member; Looks good to me, approved As this is a new feature, it's currently not allowed to be merged due to feature freeze. However, I'd still like to get this in as it's a nice enhancement esp. when you're not administering the DB server yourself but have limited rights to create new databases. Xavier, what do you think?
  1. Andreas Wolf uploaded patch set 6 10/26/11, 14:36

  2. Andreas Wolf commented on patch set 6 V 0 10/26/11, 14:36

    by team member; Looks good to me, approved Merging this as it already had enough votes. Only change in Patchset 6 is the "Releases: 4.7" in the commit message.
  3. Stefan Neufeind commented on patch set 5 10/26/11, 14:36

    took care of Xavier's suggestion. Please note 3 people already reviewed this and there was 1 verified. I guess we could get this finished?
  4. Stefan Neufeind uploaded patch set 5 10/26/11, 14:36

  5. Stefan Neufeind commented on patch set 5 10/26/11, 14:36

    Looks good to me, but someone else must approve
  6. Stefan Neufeind commented on patch set 5 10/26/11, 14:36

    Xavier, could this be an exception (only touches/enhances the installer, ...) or should this be for 4.7?
  7. Xavier Perseguers commented on patch set 1 10/26/11, 14:36

    Looks good to me, but someone else must approve Hi, in fact the hook used by DBAL prepares the form and then a condition that is not shown in your patch makes sure it goes into the standard form preparation only if the markers were not already defined, which is the case when using DBAL. As such, it's safe and the code looks good.
  8. Xavier Perseguers commented on patch set 4 1 comment 10/26/11, 14:36

    Looks good to me, but someone else must approve
  9. Xavier Perseguers commented on patch set 5 10/26/11, 14:36

    Do not submit Feature freeze is over and I prefer not merging this anyway into 4.6 as I don't have enough time to test it on different types of environments and underlying DBMS. This should be part of 4.7 and the commit message should have a Releases: entry in addition.
  10. Xavier Perseguers commented on patch set 5 10/26/11, 14:36

    Looks good to me, but someone else must approve
  11. Xavier Perseguers commented on patch set 6 10/26/11, 14:36

    No score No more reason to block this one.
  12. Georg Ringer commented on patch set 3 10/26/11, 14:36

    Looks good to me, but someone else must approve

    StepOutput.html:86

    ###FORMFIELD_ATTRIBUTES_NEW### would be better to read

    StepOutput.html:91

    maybe ###DATABASE_NAME_PATTERNS###?

    StepOutput.html:92

    why not LL_DB_PATTERN_REMARK and maybe also DB_ at the line above instead of DATABASE?

    class.tx_install.php:1116

    if ($createDatabaseAllowed) should be enough

    class.tx_install.php:1136

    and (!usePatternList)
  13. Georg Ringer commented on patch set 4 10/26/11, 14:36

    Looks good to me, but someone else must approve
  14. Steffen Gebert commented on patch set 1 10/26/11, 14:36

    Of course, this has to be adopted for DBAL
  15. Steffen Gebert commented on patch set 1 10/26/11, 14:36

    Okay, that's information which I really hoped to get during the review process. Can you post the mentioned configuration?
  16. Steffen Gebert commented on patch set 1 10/26/11, 14:36

    The whole thing shouldn't conflict with DBAL, as it completely replaces the database setup steps. But for safety, could you check this, Xavier? Thx
  17. Kay Strobach commented on patch set 4 10/26/11, 14:36

    Verified; Looks good to me, but someone else must approve good patch, but i think this is low priority ;)
  18. Mr. Jenkins commented on patch set 1 10/26/11, 14:36

  19. Mr. Jenkins commented on patch set 2 10/26/11, 14:36

  20. Mr. Jenkins commented on patch set 3 10/26/11, 14:36

  21. Mr. Jenkins commented on patch set 4 10/26/11, 14:36

  22. Mr. Jenkins commented on patch set 5 10/26/11, 14:36

  23. Mr. Jenkins commented on patch set 6 10/26/11, 14:36

  24. Andreas Wolf commented on patch set 6 10/26/11, 14:36

    Merging this as the previous version had enough +1s and there is no significant change in this new version.
  25. Andreas Wolf merged patch set 6 10/26/11, 14:36