Review main Merged

2509[BUGFIX] Wrong usage of Ext.encodeURL in TBE_EDITOR.rawurlencode

Marco Huber CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

If we want to use Ext.encodeURL() here, we have to change many other
things, too. Better use encodeURIComponent() here.
Ext.encodeURL() was introduced with #25350.

Review

  • Code review CR +2
    • Andreas Wolf +2
    • Stefan Neufeind +1
    • Stefan Aebischer +1
  • Verified V +2
    • Andreas Wolf +2
    • Stefan Aebischer +1

Issues 1

Files 1

Review log 10

  1. Steffen Gebert commented on patch set 1 07/08/11, 08:22

    According to Git conventions the commit message has to be manually wrapped after 72 chars (most Git tools rely on this and would end up in very long lines). I will push an updated version for you.
  2. Andreas Wolf commented on patch set 2 07/08/11, 08:22

    Verified; Looks good to me, but someone else must approve
  3. Andreas Wolf commented on patch set 2 V 0 07/08/11, 08:22

    by team member; Looks good to me, approved Pushing after another positive review.
  4. Stefan Neufeind commented on patch set 2 07/08/11, 08:22

    small, well described change
  5. Stefan Neufeind commented on patch set 2 07/08/11, 08:22

    Looks good to me, but someone else must approve
  6. Steffen Gebert uploaded patch set 2 07/08/11, 08:22

  7. Stefan Aebischer commented on patch set 2 07/08/11, 08:22

    Verified; Looks good to me, but someone else must approve
  8. Mr. Jenkins commented on patch set 1 07/08/11, 08:22

  9. Mr. Jenkins commented on patch set 2 07/08/11, 08:22

  10. Andreas Wolf merged patch set 2 07/08/11, 08:22