Review main Merged

25152[BUGFIX] Endless loop in check for broken extensions

Oliver Hader CR +2 V +2 Easy +1 −0 updated 11/07/13, 09:15

Commit message

The check for broken extensions in the Install Tool checks for
PHP fatal errors, excludes possibly faulty extensions and
continues this process until all errors are gone or all
extensions have been marked as broken.

If PHP warnings (or any other content) are outputted directly
to the client, this will lead to a mixed data representation of
JSON encoded content and the plain text output, like e.g.
  Warning:  array_keys() expects parameter 1 to be array...
  "OK"

To avoid that, the output buffer needs to be cleaned.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Markus Klein +1
    • Philipp Gampe +1
  • Verified V +2
    • Oliver Hader +2

Files 1

Review log 5

  1. Mr. Jenkins commented on patch set 1 11/04/13, 13:18

  2. Philipp Gampe commented on patch set 1 CR +1 11/06/13, 20:27

    nobrainer IMHO
  3. Markus Klein voted on patch set 1 CR +1 11/06/13, 22:14

  4. Oliver Hader voted on patch set 1 V +2 CR +2 11/07/13, 09:15

  5. Oliver Hader merged patch set 2 11/07/13, 09:15