Review main Abandoned

25159[BUGFIX] Migration of files breaks in Installtool

Stefan Froemken CR 0 V 0 Easy +6 −1 updated 12/13/14, 14:41

Commit message

Although we checked for existing files, getFile() throws
a File_Not_Exists-Exception in some cases. This
patch checks for an Exception and sets $file to NULL.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 7

  1. Mr. Jenkins commented on patch set 1 11/04/13, 17:27

  2. Wouter Wolters commented on patch set 1 11/04/13, 17:40

    @stefan https://review.typo3.org/#/c/25004/ is similar but another wizard, wanna have a look and review?
  3. Wouter Wolters voted on patch set 1 CR +1 11/04/13, 17:41

  4. Frans Saris commented on patch set 1 CR -1 11/04/13, 19:16

    When the file doesn't exist there is something else wrong. A few lines above this change is already a file_exists() check. So if here the file doesn't exist the renaming failed and that should be handled and wizard should break/stop so you can fix write permissions.
  5. Frans Saris wrote 09/09/14, 10:08

    Removed the following approvals: * Code-Review-1 by Frans Saris <franssaris@gmail.com>
  6. Wouter Wolters commented on patch set 1 CR -1 12/13/14, 14:20

    This class is not there anymore in master
  7. Wouter Wolters abandoned the change 12/13/14, 14:41

    This has been resolved in a different way already for 6.2