Review main Merged

25194[BUGFIX] File PackageStates.php isn't created at all

Nicole Hummel CR +2 V +2 Easy +10 −4 updated 11/08/13, 12:53

Commit message

With the patch I71bba56361a4cc85fb253199acbfee5829defa29 the access to
the PackageStates.php file is checked. If the file doesn't exists yet
the error is thrown as well. This patch adds a test if the file can be
created so the update process can be executed again.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Wouter Wolters +1
    • Alexander Schnitzler +1
  • Verified V +2
    • Stefan Neufeind +2
    • Alexander Schnitzler +1

Issues 1

Files 2

Review log 9

  1. Thomas Maroschik voted on patch set 1 CR +1 11/07/13, 12:19

  2. Mr. Jenkins commented on patch set 1 11/07/13, 12:26

  3. Christian Kuhn commented on patch set 1 11/07/13, 15:36

    Please add a change to the readme within this flow structure to document that we changed the code for this change and the change before.
  4. Nicole Hummel uploaded patch set 2 11/07/13, 19:46

  5. Wouter Wolters voted on patch set 2 CR +1 11/07/13, 19:48

  6. Mr. Jenkins commented on patch set 2 11/07/13, 19:57

  7. Alexander Schnitzler voted on patch set 2 V +1 CR +1 11/08/13, 10:14

  8. Stefan Neufeind voted on patch set 2 V +2 CR +2 11/08/13, 12:53

  9. Stefan Neufeind merged patch set 3 11/08/13, 12:53