2521[BUGFIX] sysext recycler: Missing space-character in info-popup
Commit message
Review
-
Code review CR +2
- Tobias Liebig +2
- Stefan Neufeind +1
- Mario Rimann +1
- Chris topher +1
-
Verified V +2
- Tobias Liebig +2
- Stefan Neufeind +1
- Chris topher +1
Issues 1
Files 2
Review log 7
-
Steffen Gebert commented on patch set 1 06/10/11, 18:04
I would prefer that you didn't submit thisYou should either work in branches (recommended) or hard-reset your master branch. This change has a not yet merged change as parent. This is only desired, if the change really builds upon the previous one (this one can't be merged by gerrit until the previous one is merged).That's organizational blabla - doesn't belong to the commit message imho (but could be added as comment or in forge).locallang.xml:31With the JS change we don't need the label to be changed, don't we? -
Mario Rimann commented on patch set 2 06/10/11, 18:04
Looks good to me, but someone else must approve -
Stefan Neufeind commented on patch set 2 06/10/11, 18:04
Verified; Looks good to me, but someone else must approve -
Tobias Liebig commented on patch set 2 V 0 06/10/11, 18:04
by team member; Looks good to me, approved Looks good to me. All fine. -
Steffen Gebert uploaded patch set 2 06/10/11, 18:04
-
Chris topher commented on patch set 2 06/10/11, 18:04
Verified; Looks good to me, but someone else must approve -
Tobias Liebig merged patch set 2 06/10/11, 18:04