Review main Merged

25211[BUGFIX] AddQueryStringMethod overwrites parameters

KJ Kooistra CR +2 V +2 Normal +144 −4 updated 06/12/14, 10:42

Commit message

Uri parameters are overwritten when using both POST and GET parameters
with the addQueryStringMethod functionality of uri generation.

The problem is solved by using the method
GeneralUtility::array_merge_recursive_overrule() instead of array_merge
when merging the POST and GET parameters.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Stefan Froemken +1
    • Xavier Perseguers +1
  • Verified V +2
    • Wouter Wolters +2
    • Wolfgang Wagner +1
    • Stefan Froemken +1
    • Xavier Perseguers +1

Issues 1

Files 4

Review log 31

Show 6 earlier messages
  1. Mr. Jenkins commented on patch set 1 CR -1 V -1 11/08/13, 13:18

  2. Tomita Militaru commented on patch set 1 CR -1 11/08/13, 13:36

    Please shorten the commit message lines to max 74 characters.
  3. KJ Kooistra uploaded patch set 2 11/08/13, 15:04

  4. Mr. Jenkins commented on patch set 2 11/08/13, 15:16

  5. Steffen Gebert commented on patch set 2 11/20/13, 20:53

    Tomita, don't you think it would be fair to also review the code? It seems to be KJ's second contribution and I think that should be honored by not only looking at the tiny glitches. Hope you agree :-) Steffen
  6. Tomita Militaru commented on patch set 2 11/20/13, 21:10

    Steffen, of course :)
  1. Steffen Gebert commented on patch set 2 11/20/13, 21:54

    Great, thanks man :-)
  2. Tomita Militaru voted on patch set 2 V +1 CR +1 11/20/13, 22:49

  3. Wouter Wolters commented on patch set 2 CR -1 03/07/14, 19:03

    UriBuilder.php:588

    ArrayUtility::mergeRecursiveWithOverrule must be used now. Same below
  4. Wouter Wolters uploaded patch set 3 03/07/14, 19:18

  5. Mr. Jenkins commented on patch set 3 03/07/14, 19:32

  6. Kasper Ligaard commented on patch set 3 03/08/14, 06:41

    Maybe the native PHP function array_replace_recursive() could be used? Ref.: http://www.php.net/array_replace_recursive
  7. Stefan Froemken voted on patch set 3 V +1 CR +1 06/12/14, 06:17

  8. Wolfgang Wagner voted on patch set 3 V +1 06/12/14, 06:55

  9. Markus Klein commented on patch set 3 06/12/14, 07:28

    UriBuilderTest.php:420

    Why not using rawurlencode()?

    ContentObjectRendererTest.php:423

    Same here
  10. Xavier Perseguers commented on patch set 3 CR -1 06/12/14, 08:02

    UriBuilderTest.php:420 Reply

    this would change every special character including the ?, the = and the &

    ContentObjectRenderer.php:6397

    Remove \TYPO3\CMS\Core\Utility\ before GeneralUtility::_POST()

    ContentObjectRenderer.php:6401

    Remove \TYPO3\CMS\Core\Utility\ before GeneralUtility::_GET()

    ContentObjectRendererTest.php:423 Reply

    same rationale
  11. Xavier Perseguers commented on patch set 3 06/12/14, 08:03

    ... overwrites parameters
    remove this last "functionality"
  12. Xavier Perseguers commented on patch set 3 06/12/14, 08:11

    ContentObjectRenderer.php:6397 Reply

    Done

    ContentObjectRenderer.php:6401 Reply

    Done
  13. Xavier Perseguers uploaded patch set 4 06/12/14, 08:13

  14. Xavier Perseguers voted on patch set 4 V +1 CR +1 06/12/14, 08:14

  15. Mr. Jenkins commented on patch set 4 06/12/14, 08:28

  16. Markus Klein commented on patch set 4 06/12/14, 09:03

    UriBuilder.php:591

    thinking about this again, I'd suggest to use the PHP native array_merge_recursive function instead of this Core function, because we don't need the extra functionality of our Core function.
  17. Xavier Perseguers commented on patch set 4 06/12/14, 09:20

    UriBuilder.php:591 Reply

    Just tried and the tests are then failing since the merge is not done the same way. Are the newly added tests actually wrong?
  18. Stefan Froemken commented on patch set 4 06/12/14, 09:42

    UriBuilder.php:591 Reply

    No. array_merge_recursive is the wrong function. Please use array_replace_recursive instead
  19. Xavier Perseguers uploaded patch set 5 06/12/14, 09:57

  20. Xavier Perseguers voted on patch set 5 V +1 CR +1 06/12/14, 09:57

  21. Mr. Jenkins commented on patch set 5 06/12/14, 10:12

  22. Wolfgang Wagner voted on patch set 5 V +1 06/12/14, 10:32

  23. Stefan Froemken voted on patch set 5 V +1 CR +1 06/12/14, 10:36

  24. Wouter Wolters voted on patch set 5 V +2 CR +2 06/12/14, 10:42

  25. Wouter Wolters merged patch set 6 06/12/14, 10:42