25211[BUGFIX] AddQueryStringMethod overwrites parameters
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Stefan Froemken +1
- Xavier Perseguers +1
-
Verified V +2
- Wouter Wolters +2
- Wolfgang Wagner +1
- Stefan Froemken +1
- Xavier Perseguers +1
Issues 1
Files 4
Review log 31
Show 6 earlier messages
-
Mr. Jenkins commented on patch set 1 CR -1 V -1 11/08/13, 13:18
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/11907/ : FAILURE -
Tomita Militaru commented on patch set 1 CR -1 11/08/13, 13:36
Please shorten the commit message lines to max 74 characters. -
KJ Kooistra uploaded patch set 2 11/08/13, 15:04
-
Mr. Jenkins commented on patch set 2 11/08/13, 15:16
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11912/ : SUCCESS -
Steffen Gebert commented on patch set 2 11/20/13, 20:53
Tomita, don't you think it would be fair to also review the code? It seems to be KJ's second contribution and I think that should be honored by not only looking at the tiny glitches. Hope you agree :-) Steffen -
Tomita Militaru commented on patch set 2 11/20/13, 21:10
Steffen, of course :)
-
Steffen Gebert commented on patch set 2 11/20/13, 21:54
Great, thanks man :-) -
Tomita Militaru voted on patch set 2 V +1 CR +1 11/20/13, 22:49
-
Wouter Wolters commented on patch set 2 CR -1 03/07/14, 19:03
UriBuilder.php:588ArrayUtility::mergeRecursiveWithOverrule must be used now. Same below -
Wouter Wolters uploaded patch set 3 03/07/14, 19:18
-
Mr. Jenkins commented on patch set 3 03/07/14, 19:32
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14694/ : SUCCESS -
Kasper Ligaard commented on patch set 3 03/08/14, 06:41
Maybe the native PHP function array_replace_recursive() could be used? Ref.: http://www.php.net/array_replace_recursive -
Stefan Froemken voted on patch set 3 V +1 CR +1 06/12/14, 06:17
-
Wolfgang Wagner voted on patch set 3 V +1 06/12/14, 06:55
-
Markus Klein commented on patch set 3 06/12/14, 07:28
UriBuilderTest.php:420Why not using rawurlencode()?ContentObjectRendererTest.php:423Same here -
Xavier Perseguers commented on patch set 3 CR -1 06/12/14, 08:02
UriBuilderTest.php:420Replythis would change every special character including the ?, the = and the &ContentObjectRenderer.php:6397Remove \TYPO3\CMS\Core\Utility\ before GeneralUtility::_POST()ContentObjectRenderer.php:6401Remove \TYPO3\CMS\Core\Utility\ before GeneralUtility::_GET()ContentObjectRendererTest.php:423Replysame rationale -
Xavier Perseguers commented on patch set 3 06/12/14, 08:03
... overwrites parametersremove this last "functionality" -
Xavier Perseguers commented on patch set 3 06/12/14, 08:11
ContentObjectRenderer.php:6397ReplyDoneContentObjectRenderer.php:6401ReplyDone -
Xavier Perseguers uploaded patch set 4 06/12/14, 08:13
-
Xavier Perseguers voted on patch set 4 V +1 CR +1 06/12/14, 08:14
-
Mr. Jenkins commented on patch set 4 06/12/14, 08:28
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16675/ : SUCCESS -
Markus Klein commented on patch set 4 06/12/14, 09:03
UriBuilder.php:591thinking about this again, I'd suggest to use the PHP native array_merge_recursive function instead of this Core function, because we don't need the extra functionality of our Core function. -
Xavier Perseguers commented on patch set 4 06/12/14, 09:20
UriBuilder.php:591ReplyJust tried and the tests are then failing since the merge is not done the same way. Are the newly added tests actually wrong? -
Stefan Froemken commented on patch set 4 06/12/14, 09:42
UriBuilder.php:591ReplyNo. array_merge_recursive is the wrong function. Please use array_replace_recursive instead -
Xavier Perseguers uploaded patch set 5 06/12/14, 09:57
-
Xavier Perseguers voted on patch set 5 V +1 CR +1 06/12/14, 09:57
-
Mr. Jenkins commented on patch set 5 06/12/14, 10:12
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16679/ : SUCCESS -
Wolfgang Wagner voted on patch set 5 V +1 06/12/14, 10:32
-
Stefan Froemken voted on patch set 5 V +1 CR +1 06/12/14, 10:36
-
Wouter Wolters voted on patch set 5 V +2 CR +2 06/12/14, 10:42
-
Wouter Wolters merged patch set 6 06/12/14, 10:42