Review main Merged

25212[BUGFIX] EM: Fetch list as html, not as json

Stefan Neufeind CR +2 V +2 Easy +2 −2 updated 02/25/14, 14:52

Commit message

After performing an update from TER currently the extension-list
is fetched as format=json. This however leads to that situation
that links in the list also have format=json and won't work
anymore (example: pagination-widget).

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Pascal Dürsteler +1
    • Xavier Perseguers +1
    • Philipp Gampe +1
  • Verified V +2
    • Stefan Neufeind +2
    • Pascal Dürsteler +1
    • Xavier Perseguers +1
    • Philipp Gampe +1

Issues 1

Files 1

Review log 16

  1. Stefan Neufeind commented on patch set 1 11/08/13, 13:46

    How to reproduce: * Open list of extensions in TER * Go to page 2 (works fine) * Update list from TER (happens via JSON) * Go to next page (fails without patch because of format=json in the pagination-URLs) Could somebody please confirm the releases-line is correct? I expect this was introduced with the new EM in 6.0.
  2. Pascal Dürsteler voted on patch set 1 CR +1 11/08/13, 13:49

  3. Mr. Jenkins commented on patch set 1 11/08/13, 13:58

  4. Xavier Perseguers commented on patch set 1 V -1 11/08/13, 14:29

    After applying the patch I get an internal server error, the list shortly refreshes then is cleared and: fatal error happens: #1294585070: No module "" could be found. together with: flash message "Update Extension List error(Internal Server Error)"
  5. Stefan Neufeind commented on patch set 1 11/08/13, 19:07

    @Xavier: I must admit I had that as well, expected a problem with cached JS or so, cleared all caches etc. and didn't receive it anymore from there on. Could you maybe check again? Or else, maybe it makes a difference if the updater found something to update or already is current? Hmm ...
  6. Philipp Gampe commented on patch set 1 V +1 CR +1 11/09/13, 08:32

    no JS or server errors for me
  7. Pascal Dürsteler commented on patch set 1 V +1 11/11/13, 10:54

    Also got the error messages Xavier had when not clearing the cache before applying the patch. Doing the steps after clearing the cache does not raise any errors.
  8. Xavier Perseguers commented on patch set 1 V +1 CR +1 11/11/13, 11:33

    Thanks for cache clearing, forgot to do it and that did the trick. I just figured out that there is actually no real ajax (but it's not new): the pagination works properly but refreshes the whole Backend module, without ajax
  9. Stefan Neufeind commented on patch set 1 V +2 CR +2 11/11/13, 17:04

    merging due to enough votes and a relatively "easy" fix
  10. Stefan Neufeind merged patch set 2 11/11/13, 17:04

  11. Stefan Neufeind commented on patch set 2 11/11/13, 17:04

    Cherry Picked This patchset was cherry picked to change: Id37ab27bb3acd821e9dc0cadb23978aa3e5d9784
  12. Stefan Neufeind commented on patch set 2 11/11/13, 17:04

    Cherry Picked This patchset was cherry picked to change: Id37ab27bb3acd821e9dc0cadb23978aa3e5d9784
  13. Markus Klein commented on patch set 2 11/15/13, 15:03

  14. Helmut Hummel commented on patch set 2 11/15/13, 17:39

    This does not work at all, leaves unused templates behind (List/Ter.json), and causes further bugs http://forge.typo3.org/issues/53661
  15. Helmut Hummel commented on patch set 2 11/15/13, 17:40

    Reverted This patchset was reverted in change: I62d1c6c06a5acb8aeed0a12226b3e7ed1bd3282b
  16. Markus Klein commented on patch set 2 02/25/14, 14:52