Review main Merged

25222[BUGFIX] Fluid paginate widget wrong number of links

KJ Kooistra CR +2 V +2 Normal +114 −1 updated 11/21/13, 07:41

Commit message

If the maximumNumberOfLinks configuration option is set to 8
the widget will render 10 links.

Solved the problem by changing a plus to a minus in the calculation
of the display range end and added unit tests for several cases.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
    • Philipp Gampe +1
  • Verified V +2
    • Wouter Wolters +2
    • Philipp Gampe +1

Issues 1

Files 2

Review log 17

  1. Mr. Jenkins commented on patch set 1 11/08/13, 16:02

  2. Markus Klein voted on patch set 1 CR +1 11/20/13, 13:04

  3. Markus Klein updated the commit message in patch set 1 11/20/13, 13:05

  4. Markus Klein commented on patch set 2 CR +1 11/20/13, 13:06

    Commit msg updated
  5. Mr. Jenkins commented on patch set 2 11/20/13, 13:20

  6. Philipp Gampe voted on patch set 2 V +1 CR +1 11/20/13, 13:25

  7. Philipp Gampe commented on patch set 2 CR 0 11/20/13, 13:26

    should go to all branches I guess ?!?
  8. Philipp Gampe updated the commit message in patch set 2 11/20/13, 13:28

  9. Philipp Gampe commented on patch set 3 V +1 CR +1 11/20/13, 13:29

    I updated the list of branches to include all 6.x branches.
  10. Mr. Jenkins commented on patch set 3 11/20/13, 13:41

  11. Markus Klein voted on patch set 3 CR +1 11/20/13, 15:31

  12. Wouter Wolters voted on patch set 3 V +2 CR +2 11/20/13, 17:54

  13. Wouter Wolters merged patch set 4 11/20/13, 17:54

  14. Wouter Wolters commented on patch set 4 11/20/13, 17:54

    Cherry Picked This patchset was cherry picked to change: Ic1c55b0bf925b546d119c67433f63e662493a08b
  15. Wouter Wolters commented on patch set 4 11/20/13, 17:54

    Cherry Picked This patchset was cherry picked to change: Ic1c55b0bf925b546d119c67433f63e662493a08b
  16. Ernesto Baschny commented on patch set 4 11/21/13, 00:40

    fluid is a backport of upstream fluid. So please fix this issue first upstream in the package https://git.typo3.org/Packages/TYPO3.Fluid.git, else we will get out of sync! Thanks!
  17. Wouter Wolters commented on patch set 4 11/21/13, 07:41