25256[FEATURE] Extending includeCSS to include files from directories
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 2
Review log 36
Show 11 earlier messages
-
Markus Klein commented on patch set 1 CR -2 11/11/13, 10:31
Hi Pascal! I've to block this patch, since time for new features has not come yet. See also my commentFeature freeze. No features anymore for 6.2. Features are not possible in released versions. We don't know yet what the next version will be. 6.3/7.0 -
Markus Klein commented on patch set 1 11/11/13, 10:33
Documentation needs to be an extra ticket in one of the Documentation projects on forge -
Pascal Dürsteler commented on patch set 1 11/11/13, 10:38
Thanks for the fast response. So, this would just be stalled until the new version is defined, then I'd just push it up there? I'm a bit new to this, still learning...Reply
Okay, thanks for the information. -
Mr. Jenkins commented on patch set 1 CR -1 V -1 11/11/13, 10:42
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/11955/ : FAILURE -
Stefan Neufeind commented on patch set 1 11/11/13, 11:50
@Pascal: Maybe clean up the patch a bit (commit-msg, spaces, ...) already? But no hurry, since it's a new feature and we have FF already. Will take a look at the proposed functionality later maybe. We already discussed this briefly.Jenkins complained about this text: Line exceeds maximum length of 74 characters (length: 86)PageGenerator.php:467tabs, not spaces! (all throughout the patch) - please adjust your editorPageGenerator.php:1040unneeded whitespace at line-ending -
Pascal Dürsteler uploaded patch set 2 11/11/13, 12:47
-
Pascal Dürsteler commented on patch set 2 11/11/13, 12:49
I shamelessly set the relase to 6.3 to not interfer with something. I also added some comments on forge about tests which are currently missing, maybe someone wants to have a peek there. -
Mr. Jenkins commented on patch set 2 11/11/13, 13:00
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11957/ : SUCCESS -
Pascal Dürsteler uploaded patch set 3 11/11/13, 14:01
-
Mr. Jenkins commented on patch set 3 11/11/13, 14:16
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/11960/ : SUCCESS -
Markus Klein voted on patch set 3 CR 0 11/11/13, 15:46
-
Ernesto Baschny commented on patch set 3 V -1 02/10/14, 09:11
Thanks, let keep that in mind focus for the next release, not for 6.2 anymore. For now we have enough to focus our energy in until 6.2 release. So I'll block until release, let me know after the release when someone wants to work on it further. -
Anja Leichsenring uploaded patch set 4 12/13/14, 11:12
-
Anja Leichsenring commented on patch set 4 CR +1 V +1 12/13/14, 11:14
rebased, tested, documentation added. nice addition. -
Stefan Neufeind commented on patch set 4 CR -1 12/13/14, 13:00
Imho we should include directories recursively as well. When including TypoScript, sub-directories are included. In TypoScriptParser the function GeneralUtility::getAllFilesAndFoldersInPath() is used - so it should be minimal work and would be consistent. -
Anja Leichsenring commented on patch set 4 12/13/14, 13:23
I would like to do one thing after the other. This feature can be extended, but how about merging now the basic and go from there? -
Stefan Neufeind commented on patch set 4 12/13/14, 14:52
Imho it's about replacing the function to gather the files to be added. So what prevents us from "doing it right"? I fear we add it now, nobody will do a followup or that will get into a never-ending discussion and then on release-day it is released "as is". -
Anja Leichsenring uploaded patch set 5 12/13/14, 20:06
-
Anja Leichsenring uploaded patch set 6 12/13/14, 20:08
-
Mathias Schreiber voted on patch set 6 CR +1 V +1 12/13/14, 20:19
-
Michael Oehlhof commented on patch set 6 12/14/14, 09:46
PageGenerator.php:1069This line has 242 characters, it should be split into multiple lines. -
Mathias Schreiber wrote 12/17/14, 20:36
Topic set to FE Page -
Anja Leichsenring commented on patch set 6 CR +1 V +1 01/18/15, 15:04
no recursive inclusion intended. -
Mathias Schreiber wrote 01/18/15, 18:18
Removed the following approvals: * Code-Review+1 by Mathias Schreiber <mathias.schreiber@wmdb.de> * Verified+1 by Mathias Schreiber <mathias.schreiber@wmdb.de> -
Markus Klein commented on patch set 6 CR -1 01/19/15, 01:26
Feature-53375-AddCssFilesFromDirectory.rst:16byPageGenerator.php:488$ss[0] !== '/'PageGenerator.php:1067no need to pass that as parameter! $GLOBALS['TSFE']->getPageRenderer()PageGenerator.php:1069simply a (bool) castPageGenerator.php:1077bool castPageGenerator.php:1079bool cast -
Benni Mack commented on patch set 6 CR -1 01/29/15, 17:39
I don't think that adding a feature like this is a proper solution. The *right* way for people these days adding CSS these days is adding merge tools, and preprocessors, not rape an existing and clean API. -
Christian Kuhn commented on patch set 6 CR -1 01/29/15, 17:39
Guys, I don't like this feature: * Next request is then to change the load order by some pattern, we've had a similar thing with the "load all TS from directory", and I don't want to repeat our errors here. * The API is not explicit and can be easily overseen. * I think its much easier, more realiable and more explicit if those files are registered in single lines. -
Stefan Neufeind commented on patch set 6 01/29/15, 19:30
As you might have guessed I like the idea to include from directories, since we also already have it for TS and since it can be quite useful. (And yes, for TS we number our files 001_... to make a deterministic loading-order easier.) -
Benni Mack commented on patch set 6 CR -2 01/29/15, 19:54
Yes. I am very much against such a change (and also against the TS functionality) as it does too much magic. Plus, I know that these things can go out of hand, as exactly happened with JS logic in 4.5, which we still have in the core (check BackendController for "sorting" of directory includes. BAD). If you want this feature, please create an extension for that. -
Stefan Neufeind commented on patch set 6 01/29/15, 19:57
Okay, differently put I'm fine with your request to handle it in an extension: Do we have a hook to modify (prepend/append to) the list of includeCSS? Same for JS and TS then, please :-) (I guess for TS there was some way to extend INCLUDE_TYPOSCRIPT). -
Benni Mack commented on patch set 6 01/29/15, 20:27
yes. all possible in the PageRenderer. Also have a look at my extension amazingless in TER that modifies includeCSS as well to preprocess LESS to CSS -
Stefan Neufeind commented on patch set 6 01/29/15, 20:32
okay, then let's close this imho -
Markus Klein commented on patch set 6 01/29/15, 22:28
@benni: the directory inclusion of TS is the greatest feature of 6.2 for me! -
Benni Mack commented on patch set 6 01/30/15, 11:10
Markus, that's fine. But I don't think that extending an existing API with this logic is bad code design. I thought about it yesterday a bit further and a new property page.includeCSSDirectory is the proper way which can easily be added within an extension. -
Anja Leichsenring commented on patch set 6 CR 0 V 0 02/04/15, 21:35
I guess strategic team has spoken. Please abandon this patch, as it gains no approval. If no one else does, I will abandon on Feb. 21th. -
Stefan Neufeind abandoned the change 02/04/15, 22:43
@Pascal: Sorry for the outcome. But I'd really appreciate if you could introduce this through some extension - separate or maybe as part of scriptmerger maybe?