Review main Merged

25302[BUGFIX] Faulty and superfluous code in import/export module

Oliver Hader CR +2 V +2 Normal +0 −232 updated 12/01/13, 10:52

Commit message

There is faulty and superfluous code in import/export module:
* ModuleFunctionController does not work at all, this points
  back to issue #22921 during TYPO3 4.4 development
* ImportExportTask fetches thumbnail files from a (faulty)
  storage that are not used at all

Since the required class "mod_user_task" has been removed in
TYPO3 4.4, the module function component was broken since then.
Thus, it will be removed completely with this change.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Oliver Klee +1
    • Markus Klein +1
  • Verified V +2
    • Christian Kuhn +2
    • Markus Klein +1

Files 7

Review log 10

  1. Mr. Jenkins commented on patch set 1 11/12/13, 12:18

  2. Markus Klein commented on patch set 1 11/12/13, 14:40

    locallang.xlf:17

    Can we remove labels?
  3. Wouter Wolters voted on patch set 1 V +1 CR +1 11/24/13, 21:13

  4. Markus Klein commented on patch set 1 CR -1 11/28/13, 23:36

    There's still a reference to tx_impexp_modfunc1 in the LegacyClassForIde.php
  5. Markus Klein uploaded patch set 2 11/28/13, 23:37

  6. Markus Klein voted on patch set 2 V +1 CR +1 11/28/13, 23:38

  7. Mr. Jenkins commented on patch set 2 11/28/13, 23:51

  8. Oliver Klee voted on patch set 2 CR +1 11/29/13, 10:26

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 12/01/13, 10:52

  10. Christian Kuhn merged patch set 3 12/01/13, 10:52