Review main Merged

2531[BUGFIX] Use runtime cache in tslib_fe::get_cache_timeout

Steffen Gebert CR +2 V +2 Easy +9 −6 updated 06/03/13, 20:49

Commit message

Thanks to #20473, start and stop times of records are now taken into
account during a page's cache lifetime calculation.
To prevent repeated computations, the value is cached inside
tslib_fe::get_cache_timeout(), using a class variable
getCacheTimeoutCache.

The Runtime Cache (#27208) not only offers a cleaner way to do so, it
also provides a remedy against the currently existing problem that
get_cache_timeout() does its job exactly twice: Once during menu
generation (which seems to work with a cloned copy of TSFE) and once
before putting the page contents into the cache. As both class instances
share the runtime cache, the second calculation can be safed.

Review

  • Code review CR +2
    • Susi Moog +2
    • Christian Kuhn +1
    • Philipp Gampe +1
  • Verified V +2
    • Susi Moog +2
    • Christian Kuhn +1
    • Philipp Gampe +1

Issues 1

Files 1

Review log 8

  1. Stefan Neufeind commented on patch set 1 06/24/11, 19:10

    Looks good to me, but someone else must approve
  2. Susi Moog commented on patch set 2 V 0 06/24/11, 19:10

    by team member; Looks good to me, approved
  3. Christian Kuhn uploaded patch set 2 06/24/11, 19:10

  4. Christian Kuhn commented on patch set 2 06/24/11, 19:10

    Verified; Looks good to me, but someone else must approve
  5. Philipp Gampe commented on patch set 2 06/24/11, 19:10

    Verified; Looks good to me, but someone else must approve works for me ... at least no error while accessing pages with timed frontend elements or timed pages.
  6. Mr. Jenkins commented on patch set 1 06/24/11, 19:10

  7. Mr. Jenkins commented on patch set 2 06/24/11, 19:10

  8. Susi Moog merged patch set 2 06/24/11, 19:10