Review TYPO3_6-1 Merged

25311[BUGFIX] Make be.buttons.icon-ViewHelper extensible

Markus Klein CR +2 V +2 Easy +18 −2 updated 11/12/13, 14:17

Commit message

Many of the standard-ViewHelpers (tag-based) at least support
additionalAttributes. Introduce this for be.buttons.icon as well
to allow for attributes like onclick or target. Those arguments
will be assigned to the surrounding a-tag if an uri is specified.

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2

Issues 1

Files 1

Review log 3

  1. Markus Klein voted on patch set 1 V +2 CR +2 11/12/13, 14:17

  2. Markus Klein merged patch set 2 11/12/13, 14:17

  3. Markus Klein commented on patch set 2 11/12/13, 14:17

    Cherry Picked This patchset was cherry picked to change: I0b8ef12842a818ed5d49437a003287aff9b08f13