Review TYPO3_4-5 Merged

2533[BUGFIX] TCEFORM language selector: wrong relations

Andreas Wolf CR +2 V +2 Easy +19 −17 updated 06/03/13, 20:49

Commit message

The language selector in the top of BE forms is intended to show (and
switch between) all translations of a certain record. All records in
non-default languages, that are not bound to a record in the default
language are shown as translations of each other.
The patch adds a distinction between translated records and records in
a non-default language to render the dropdowns labels and functions.
Additionally fixes PHPDoc and indentation of
SC_alt_doc::languageSwitch().

Review

  • Code review CR +2
    • Andreas Wolf +2
    • Thorsten Kahler +1
  • Verified V +2
    • Andreas Wolf +2
    • Thorsten Kahler +1

Issues 1

Files 1

Review log 6

  1. Thorsten Kahler commented on patch set 2 06/06/11, 10:45

    Verified; Looks good to me, but someone else must approve
  2. Andreas Wolf commented on patch set 2 V 0 06/06/11, 10:45

    by team member; Looks good to me, approved Pushing this one after Thorstens approval - the patch is the same as for master, except some whitespace changes.
  3. Andreas Wolf uploaded patch set 2 06/06/11, 10:45

  4. Mr. Jenkins commented on patch set 1 06/06/11, 10:45

  5. Mr. Jenkins commented on patch set 2 06/06/11, 10:45

  6. Andreas Wolf merged patch set 2 06/06/11, 10:45