Review main Merged

25365[BUGFIX] No placeholder attribute in backend forms

Oliver Hader CR +2 V +2 Easy +1 −1 updated 01/23/14, 13:38

Commit message

The disposal of the placeholder feature in backend forms needs
to be enabled using the mode setting "useOrOverridePlaceholder"
in TCA. However, the implementation for checking this needs to
be inverted, since it returns an empty string if it's enabled,
but should be the opposite way instead.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Files 1

Review log 15

  1. Mr. Jenkins commented on patch set 1 11/13/13, 09:58

  2. Christian Kuhn voted on patch set 1 V +1 CR +1 11/13/13, 21:23

  3. Markus Klein commented on patch set 1 CR -1 11/13/13, 21:39

    Please check my comment

    FormEngine.php:6489

    This seems wrong here. ! takes precedence before the === should be !== I guess
  4. Christian Kuhn voted on patch set 1 CR 0 11/13/13, 21:48

  5. Oliver Hader uploaded patch set 2 11/15/13, 09:20

  6. Oliver Hader commented on patch set 1 11/15/13, 09:21

    Thx, that was a bug indeed...

    FormEngine.php:6489 Reply

    Done
  7. Mr. Jenkins commented on patch set 2 11/15/13, 09:36

  8. Wouter Wolters voted on patch set 2 CR +1 11/15/13, 10:27

  9. Markus Klein rebased onto patch set 2 01/16/14, 22:53

  10. Markus Klein commented on patch set 3 V +1 CR +1 01/16/14, 22:54

    no-brainer. Will merge in 24h if nobody objects
  11. Mr. Jenkins commented on patch set 3 01/16/14, 23:28

  12. Wouter Wolters voted on patch set 3 V +2 CR +2 01/18/14, 13:15

  13. Wouter Wolters merged patch set 4 01/18/14, 13:15

  14. Markus Klein commented on patch set 4 01/19/14, 11:55

    @Olly: Why is this targeted for 6.1 and 6.0? The code does not exist there...
  15. Oliver Hader commented on patch set 4 01/23/14, 13:38

    @Markus: I looked up the change that introduced the misbehavior and that mentioned 6.1 and 6.0 as well in the release line. However it seems, that it has actually NOT been backported to older branches. see https://review.typo3.org/#/c/21931/