25365[BUGFIX] No placeholder attribute in backend forms
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Markus Klein +1
-
Verified V +2
- Wouter Wolters +2
- Markus Klein +1
Files 1
Review log 15
-
Mr. Jenkins commented on patch set 1 11/13/13, 09:58
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12042/ : SUCCESS -
Christian Kuhn voted on patch set 1 V +1 CR +1 11/13/13, 21:23
-
Markus Klein commented on patch set 1 CR -1 11/13/13, 21:39
Please check my commentFormEngine.php:6489This seems wrong here. ! takes precedence before the === should be !== I guess -
Christian Kuhn voted on patch set 1 CR 0 11/13/13, 21:48
-
Oliver Hader uploaded patch set 2 11/15/13, 09:20
-
Oliver Hader commented on patch set 1 11/15/13, 09:21
Thx, that was a bug indeed...FormEngine.php:6489ReplyDone -
Mr. Jenkins commented on patch set 2 11/15/13, 09:36
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12077/ : SUCCESS -
Wouter Wolters voted on patch set 2 CR +1 11/15/13, 10:27
-
Markus Klein rebased onto patch set 2 01/16/14, 22:53
-
Markus Klein commented on patch set 3 V +1 CR +1 01/16/14, 22:54
no-brainer. Will merge in 24h if nobody objects -
Mr. Jenkins commented on patch set 3 01/16/14, 23:28
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13067/ : SUCCESS -
Wouter Wolters voted on patch set 3 V +2 CR +2 01/18/14, 13:15
-
Wouter Wolters merged patch set 4 01/18/14, 13:15
-
Markus Klein commented on patch set 4 01/19/14, 11:55
@Olly: Why is this targeted for 6.1 and 6.0? The code does not exist there... -
Oliver Hader commented on patch set 4 01/23/14, 13:38
@Markus: I looked up the change that introduced the misbehavior and that mentioned 6.1 and 6.0 as well in the release line. However it seems, that it has actually NOT been backported to older branches. see https://review.typo3.org/#/c/21931/