Review main Merged

2538[FEATURE] Add random functionality to listNum

Mario Rimann CR +2 V +2 Easy +4 −0 updated 06/03/13, 20:49

Commit message

Add the ability to get a random item by setting listNum to "rand".

Review

  • Code review CR +2
    • Steffen Gebert +2
    • Stefan Neufeind +1
    • Mario Rimann +1
    • Georg Ringer +1
  • Verified V +2
    • Steffen Gebert +2
    • Georg Ringer +1

Issues 1

Files 1

Review log 22

  1. Mario Rimann uploaded patch set 2 06/24/11, 21:56

  2. Mario Rimann commented on patch set 2 06/24/11, 21:56

    I would prefer that you didn't submit this whoops, pushed the wrong code without the requested changes (just learning Git and Gerrit, mea culpa!)
  3. Mario Rimann uploaded patch set 3 06/24/11, 21:56

  4. Mario Rimann commented on patch set 4 06/24/11, 21:56

    Would be nice if someone could change the commit message according to the previous comment.
  5. Mario Rimann uploaded patch set 4 06/24/11, 21:56

  6. Stefan Neufeind commented on patch set 1 06/24/11, 21:56

    Looks good to me, but someone else must approve

    class.tslib_content.php:3294

    fine; reviewed that return from rand() also includes min/max-values
  7. Steffen Gebert commented on patch set 1 06/24/11, 21:56

    I would prefer that you didn't submit this CGL nitpicking only
    Mario, please add : after Resolves. I fear, otherwise the packaging script will not recognize the line during ChangeLog generation.

    class.tslib_content.php:3292

    please indent comment by 1 tab

    class.tslib_content.php:3294

    Please add spaces after , and around - . Thx
  8. Francois Suter commented on patch set 5 06/24/11, 21:56

    If I'm not mistaken, there's nothing about this in the pending doc page yet.
  9. Mario Rimann commented on patch set 5 06/24/11, 21:56

    I've added some instructions on how to test the new behaviour to the forge issue.
  10. Mario Rimann commented on patch set 5 06/24/11, 21:56

    Looks good to me, but someone else must approve Thanks for changing the commit message!
  11. Stefan Neufeind commented on patch set 5 06/24/11, 21:56

    Looks good to me, but someone else must approve
  12. Georg Ringer commented on patch set 5 06/24/11, 21:56

    Looks good to me, but someone else must approve
  13. Georg Ringer voted on patch set 5 V 0 06/24/11, 21:56

  14. Steffen Gebert uploaded patch set 5 06/24/11, 21:56

  15. Steffen Gebert commented on patch set 5 V 0 06/24/11, 21:56

    by team member; Looks good to me, approved Please don't forget to add the note to the Pending Documentation page in the wiki!
  16. Steffen Gebert merged patch set 5 06/24/11, 21:56

  17. Mr. Jenkins commented on patch set 1 06/24/11, 21:56

  18. Mr. Jenkins commented on patch set 2 06/24/11, 21:56

  19. Mr. Jenkins commented on patch set 3 06/24/11, 21:56

  20. Mr. Jenkins commented on patch set 4 06/24/11, 21:56

  21. Mr. Jenkins commented on patch set 5 06/24/11, 21:56

  22. Mario Rimann commented on patch set 5 06/24/11, 21:56

    @Francois I've just added something to the pending documentation page, wasn't aware that I should have added that before the code change is merged