2538[FEATURE] Add random functionality to listNum
Commit message
Review
-
Code review CR +2
- Steffen Gebert +2
- Stefan Neufeind +1
- Mario Rimann +1
- Georg Ringer +1
-
Verified V +2
- Steffen Gebert +2
- Georg Ringer +1
Issues 1
Files 1
Review log 22
-
Mario Rimann uploaded patch set 2 06/24/11, 21:56
-
Mario Rimann commented on patch set 2 06/24/11, 21:56
I would prefer that you didn't submit this whoops, pushed the wrong code without the requested changes (just learning Git and Gerrit, mea culpa!) -
Mario Rimann uploaded patch set 3 06/24/11, 21:56
-
Mario Rimann commented on patch set 4 06/24/11, 21:56
Would be nice if someone could change the commit message according to the previous comment. -
Mario Rimann uploaded patch set 4 06/24/11, 21:56
-
Stefan Neufeind commented on patch set 1 06/24/11, 21:56
Looks good to me, but someone else must approveclass.tslib_content.php:3294fine; reviewed that return from rand() also includes min/max-values -
Steffen Gebert commented on patch set 1 06/24/11, 21:56
I would prefer that you didn't submit this CGL nitpicking onlyMario, please add : after Resolves. I fear, otherwise the packaging script will not recognize the line during ChangeLog generation.class.tslib_content.php:3292please indent comment by 1 tabclass.tslib_content.php:3294Please add spaces after , and around - . Thx -
Francois Suter commented on patch set 5 06/24/11, 21:56
If I'm not mistaken, there's nothing about this in the pending doc page yet. -
Mario Rimann commented on patch set 5 06/24/11, 21:56
I've added some instructions on how to test the new behaviour to the forge issue. -
Mario Rimann commented on patch set 5 06/24/11, 21:56
Looks good to me, but someone else must approve Thanks for changing the commit message! -
Stefan Neufeind commented on patch set 5 06/24/11, 21:56
Looks good to me, but someone else must approve -
Georg Ringer commented on patch set 5 06/24/11, 21:56
Looks good to me, but someone else must approve -
Georg Ringer voted on patch set 5 V 0 06/24/11, 21:56
-
Steffen Gebert uploaded patch set 5 06/24/11, 21:56
-
Steffen Gebert commented on patch set 5 V 0 06/24/11, 21:56
by team member; Looks good to me, approved Please don't forget to add the note to the Pending Documentation page in the wiki! -
Steffen Gebert merged patch set 5 06/24/11, 21:56
-
Mr. Jenkins commented on patch set 1 06/24/11, 21:56
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/631/ : SUCCESS -
Mr. Jenkins commented on patch set 2 06/24/11, 21:56
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/637/ : SUCCESS -
Mr. Jenkins commented on patch set 3 06/24/11, 21:56
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/638/ : SUCCESS -
Mr. Jenkins commented on patch set 4 06/24/11, 21:56
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/639/ : SUCCESS -
Mr. Jenkins commented on patch set 5 06/24/11, 21:56
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/642/ : SUCCESS -
Mario Rimann commented on patch set 5 06/24/11, 21:56
@Francois I've just added something to the pending documentation page, wasn't aware that I should have added that before the code change is merged