Review TYPO3_4-5 Merged

25407[BUGFIX] Fix broken edit icons on cType HTML

Stefan Neufeind CR +2 V +2 Easy +12 −6 updated 11/14/13, 23:33

Commit message

Fix the wrong Typoscript configuration for front-end edit icons
for cType HTML (for the traditional fe-editing).

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Markus Klein +1
  • Verified V +2
    • Stefan Neufeind +2
    • Markus Klein +1

Issues 1

Files 6

Review log 4

  1. Stefan Neufeind commented on patch set 1 11/14/13, 17:34

    (almost) straight backport - but would be great if somebody could maybe retest this on 4.5, just to be save it also applies to 4.x cleanly
  2. Markus Klein commented on patch set 1 V +1 CR +1 11/14/13, 22:47

    Since this was reported on 4.1 and the editIcons features not been changed for ages. This look rather safe.
  3. Stefan Neufeind commented on patch set 1 V +2 CR +2 11/14/13, 23:33

    Thanks Markus for your comment. I felt the same.
  4. Stefan Neufeind merged patch set 2 11/14/13, 23:33