Review main Merged

25460[BUGFIX] Fix height of body in backend

Jost Baron CR +2 V +2 Easy +1 −2 updated 11/18/13, 23:08

Commit message

The body-tag had 100% height in the backend. In views, where scrolling
is possible (e.g. login screen in a small window), this made the
background-color stop too soon.

Review

  • Code review CR +2
    • Wouter Wolters +2
  • Verified V +2
    • Wouter Wolters +2

Issues 1

Files 2

Review log 7

  1. Jost Baron commented on patch set 1 11/16/13, 14:56

    Only checked login screen and element browser, didn't find any other problematic views. Checked in FF 25.0, Chromium 30.0.1599.114 Ubuntu 13.10, Opera 12.16, IE 7-10 with developer tools from IE10. Needs additional checking in old natively installed IEs, and Safari.
  2. Mr. Jenkins commented on patch set 1 11/16/13, 15:06

  3. Felix Kopp voted on patch set 1 V +2 CR +1 11/17/13, 09:43

  4. Markus Klein updated the commit message in patch set 1 11/18/13, 00:12

  5. Mr. Jenkins commented on patch set 2 11/18/13, 00:23

  6. Wouter Wolters commented on patch set 2 V +2 CR +2 11/18/13, 23:08

    Keeping Felix his vote in as valid.
  7. Wouter Wolters merged patch set 3 11/18/13, 23:08