25467[BUGFIX] Install System Extensions in update wizard fails
Commit message
Review
-
Code review CR +2
- Steffen Müller +2
- Thomas Maroschik +1
-
Verified V +2
- Steffen Müller +2
- Thomas Maroschik +1
Issues 1
Files 1
Review log 8
-
Mr. Jenkins commented on patch set 1 11/16/13, 22:15
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12120/ : SUCCESS -
Steffen Müller voted on patch set 1 V +1 11/16/13, 22:27
-
Steffen Müller commented on patch set 1 11/16/13, 23:33
sysexts install successfully after applying the patch (+1 verified). But I don't really get the reason why this needs to be fixed in Bootstrap like this. I'd be happy to learn more about that. -
Thomas Maroschik commented on patch set 1 11/17/13, 18:13
@Steffen The issue appears in the Install Utility where the Package Manager is injected by DI. DI talks to makeInstance in the last step. In the Install Tool the Failsafe Package Manager is initialized instead of the regular PM and makeInstance gets the wrong singleton set. DI thus injects an uninitialized standard PM into the Install Utility. -
Thomas Maroschik voted on patch set 1 V +1 CR +1 11/17/13, 18:13
-
Steffen Müller commented on patch set 1 CR +1 11/18/13, 09:56
Tom, thanks for the clarification. IMHO the first thing after 6.2 release should be to use the Flow/Extbase objectManager with DI for the whole core. -
Steffen Müller commented on patch set 1 V +2 CR +2 11/18/13, 10:01
Install tool relies on Extensionmanager code which uses Extbase DI, while Install tool uses makeInstance() DI. Too much complexity -
Steffen Müller merged patch set 2 11/18/13, 10:01