25479[CLEANUP] Improve code style of RelationHandler class
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Markus Klein +1
- Wouter Wolters +1
-
Verified V +2
- Stefan Neufeind +2
- Markus Klein +1
Issues 1
Files 1
Review log 39
Show 14 earlier messages
-
Mr. Jenkins commented on patch set 1 11/17/13, 20:48
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12128/ : SUCCESS -
Alexander Opitz commented on patch set 1 CR -1 11/18/13, 10:08
RelationHandler.php:153Public? I think this is more internal use.RelationHandler.php:892Removing of this return is an API change. Also I would exspect from a function called "get..." to return something. -
Alexander Stehlik commented on patch set 1 11/18/13, 10:14
RelationHandler.php:153ReplyYes, it most probably is. But at the moment this field is created when used in the code on the fly. And this makes it public. I did not want to change that. But if you agree I can do that :)RelationHandler.php:892ReplyThis is true. I will instead change the PHPDoc which currently says that this method returns void. -
Alexander Opitz commented on patch set 1 11/18/13, 10:25
RelationHandler.php:153ReplyIMHO, it doesn't existed in the class documentation so it wasn't in the API. Later we may need to deprecate it to get a cleaner API. On the other side, we should deprecate all this $MM_ properties ... later ... so mark it public but with @deprecate ;) -
Alexander Stehlik uploaded patch set 2 11/18/13, 10:42
-
Alexander Opitz voted on patch set 2 CR +1 11/18/13, 10:53
-
Mr. Jenkins commented on patch set 2 11/18/13, 10:56
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12135/ : SUCCESS -
Wouter Wolters voted on patch set 2 CR +1 11/18/13, 22:57
-
Alexander Stehlik uploaded patch set 3 11/21/13, 13:28
-
Alexander Stehlik uploaded patch set 4 11/21/13, 13:32
-
Alexander Stehlik commented on patch set 4 11/21/13, 13:32
Rebased to current master. -
Mr. Jenkins commented on patch set 3 CR -1 V -1 11/21/13, 13:43
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/12245/ : FAILURE -
Mr. Jenkins commented on patch set 4 11/21/13, 13:56
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12246/ : SUCCESS -
Markus Klein commented on patch set 4 11/21/13, 14:00
I'd call it a [CLEANUP]RelationHandler.php:152We cannot do this, since the devs get no warning that this is used publicly. We have this damn problem everywhere.RelationHandler.php:947no need to compare against TRUE again
-
Markus Klein commented on patch set 4 CR -1 11/21/13, 14:02
I'll push a new version -
Markus Klein uploaded patch set 5 11/21/13, 14:17
-
Mr. Jenkins commented on patch set 5 11/21/13, 14:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12248/ : SUCCESS -
Alexander Stehlik commented on patch set 5 11/21/13, 14:41
Thanks for the update :) Just one small remark.RelationHandler.php:1018Did you ignore your own comment? ;) -
Markus Klein uploaded patch set 6 11/21/13, 15:45
-
Markus Klein commented on patch set 4 11/21/13, 15:46
Reply
DoneRelationHandler.php:152ReplyDoneRelationHandler.php:947ReplyDone -
Mr. Jenkins commented on patch set 6 11/21/13, 16:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12253/ : SUCCESS -
Markus Klein voted on patch set 6 V +1 CR +1 11/21/13, 16:09
-
Alexander Opitz voted on patch set 6 V +1 CR +1 11/21/13, 16:16
-
Markus Klein commented on patch set 6 11/21/13, 16:21
If it's still allowed to merge this, we can do it, otherwise it has to wait after the beta release today. @Ernesto: please decide and if positive just merge it. thx. -
Wouter Wolters commented on patch set 6 11/21/13, 21:10
One question, further code looks okay to me.RelationHandler.php:235TRUE : FALSE? -
Markus Klein commented on patch set 6 11/21/13, 22:01
RelationHandler.php:235Replyor even a simple typecast? -
Stefan Neufeind commented on patch set 6 CR +1 11/24/13, 01:56
just a nitpickRelationHandler.php:588actually: from $oldMMs_inclUidRelationHandler.php:1024Imho a change in behaviour. Currently it would have returned NULL if updateReferenceIndex was FALSE. But I think it is okay. -
Markus Klein uploaded patch set 7 11/24/13, 08:16
-
Markus Klein commented on patch set 6 11/24/13, 08:16
RelationHandler.php:235ReplyDoneRelationHandler.php:588ReplyDoneRelationHandler.php:1024ReplyYes, doesn't matter. The return value is never used anywhere and now it complies to the phpdoc -
Markus Klein commented on patch set 7 V +1 CR +1 11/24/13, 08:16
Fixed the last comments. -
Mr. Jenkins commented on patch set 7 11/24/13, 08:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12300/ : SUCCESS -
Stefan Neufeind commented on patch set 7 11/24/13, 18:15
RelationHandler.php:235boolean -
Markus Klein uploaded patch set 8 11/24/13, 18:30
-
Markus Klein commented on patch set 7 11/24/13, 18:30
RelationHandler.php:235ReplyDidn't know that both is correct here. Done. -
Markus Klein voted on patch set 8 V +1 CR +1 11/24/13, 18:31
-
Wouter Wolters voted on patch set 8 CR +1 11/24/13, 18:32
-
Stefan Neufeind voted on patch set 8 V +2 CR +2 11/24/13, 18:36
-
Stefan Neufeind merged patch set 9 11/24/13, 18:36
-
Mr. Jenkins commented on patch set 8 11/24/13, 18:43
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12306/ : SUCCESS