25482[BUGFIX] Form Wizard saving destroys Radio Buttons
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
-
Verified V +2
- Stefan Neufeind +2
Issues 1
Files 1
Review log 19
-
Mr. Jenkins commented on patch set 1 11/18/13, 10:42
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12133/ : SUCCESS -
Markus Klein rebased onto patch set 1 12/02/13, 11:22
-
Mr. Jenkins commented on patch set 2 12/02/13, 11:54
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12439/ : SUCCESS -
Mario Rimann voted on patch set 2 CR +1 12/02/13, 12:24
-
Markus Klein rebased onto patch set 2 12/12/13, 01:44
-
Mr. Jenkins commented on patch set 3 12/12/13, 02:34
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12571/ : SUCCESS -
Mario Rimann voted on patch set 3 CR +1 12/12/13, 07:16
-
Mario Rimann commented on patch set 3 12/16/13, 15:31
Ping -
Markus Klein commented on patch set 3 12/16/13, 15:37
Mario, can you verify it too? -
Mario Rimann commented on patch set 3 V +1 12/18/13, 06:59
Verified successfully against master (fd014c2737) -
David Hoeckele voted on patch set 3 CR +1 12/18/13, 07:27
-
Stefan Neufeind commented on patch set 3 CR +1 12/18/13, 12:36
general +1, just nitpicks/suggestionsFormsController.php:732How about just one replacement? Tested here. And we could leave out the space after the comma, right? $options = str_replace(array( CR . LF, CR, LF), ',', $options); -
Markus Klein commented on patch set 3 12/18/13, 12:49
FormsController.php:732Replycorrect. but please leave the space for readability in the content element then. -
Stefan Neufeind uploaded patch set 4 12/18/13, 12:56
-
Stefan Neufeind commented on patch set 4 V +2 CR +2 12/18/13, 12:59
just formatting, votes still count -
Stefan Neufeind merged patch set 5 12/18/13, 12:59
-
Stefan Neufeind commented on patch set 5 12/18/13, 12:59
Cherry Picked This patchset was cherry picked to change: I9a88be010a7dd982776bee4a98ba99d97fcc406b -
Stefan Neufeind commented on patch set 5 12/18/13, 13:00
Cherry Picked This patchset was cherry picked to change: I9a88be010a7dd982776bee4a98ba99d97fcc406b -
Mr. Jenkins commented on patch set 4 12/18/13, 13:09
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12612/ : SUCCESS