Review main Merged

25482[BUGFIX] Form Wizard saving destroys Radio Buttons

Markus Klein CR +2 V +2 Easy +6 −1 updated 12/18/13, 13:09

Commit message

This fixes a wrong parsing of \r\n characters for radio
button options.

Review

  • Code review CR +2
    • Stefan Neufeind +2
  • Verified V +2
    • Stefan Neufeind +2

Issues 1

Files 1

Review log 19

  1. Mr. Jenkins commented on patch set 1 11/18/13, 10:42

  2. Markus Klein rebased onto patch set 1 12/02/13, 11:22

  3. Mr. Jenkins commented on patch set 2 12/02/13, 11:54

  4. Mario Rimann voted on patch set 2 CR +1 12/02/13, 12:24

  5. Markus Klein rebased onto patch set 2 12/12/13, 01:44

  6. Mr. Jenkins commented on patch set 3 12/12/13, 02:34

  7. Mario Rimann voted on patch set 3 CR +1 12/12/13, 07:16

  8. Mario Rimann commented on patch set 3 12/16/13, 15:31

    Ping
  9. Markus Klein commented on patch set 3 12/16/13, 15:37

    Mario, can you verify it too?
  10. Mario Rimann commented on patch set 3 V +1 12/18/13, 06:59

    Verified successfully against master (fd014c2737)
  11. David Hoeckele voted on patch set 3 CR +1 12/18/13, 07:27

  12. Stefan Neufeind commented on patch set 3 CR +1 12/18/13, 12:36

    general +1, just nitpicks/suggestions

    FormsController.php:732

    How about just one replacement? Tested here. And we could leave out the space after the comma, right? $options = str_replace(array( CR . LF, CR, LF), ',', $options);
  13. Markus Klein commented on patch set 3 12/18/13, 12:49

    FormsController.php:732 Reply

    correct. but please leave the space for readability in the content element then.
  14. Stefan Neufeind uploaded patch set 4 12/18/13, 12:56

  15. Stefan Neufeind commented on patch set 4 V +2 CR +2 12/18/13, 12:59

    just formatting, votes still count
  16. Stefan Neufeind merged patch set 5 12/18/13, 12:59

  17. Stefan Neufeind commented on patch set 5 12/18/13, 12:59

    Cherry Picked This patchset was cherry picked to change: I9a88be010a7dd982776bee4a98ba99d97fcc406b
  18. Stefan Neufeind commented on patch set 5 12/18/13, 13:00

    Cherry Picked This patchset was cherry picked to change: I9a88be010a7dd982776bee4a98ba99d97fcc406b
  19. Mr. Jenkins commented on patch set 4 12/18/13, 13:09