Review main Merged

25483[BUGFIX] additionalAttributes for be.buttons.icon-VH misses hsc

Markus Klein CR +2 V +2 Easy +1 −1 updated 11/18/13, 13:42

Commit message

The values of the additional attributes for the backend icon viewhelper
need to be processed through htmlspecialchars().

Review

  • Code review CR +2
    • Marc Bastian Heinrichs +2
    • Wouter Wolters +1
    • Eric Chavaillaz +1
  • Verified V +2
    • Marc Bastian Heinrichs +2
    • Eric Chavaillaz +1

Issues 1

Files 1

Review log 7

  1. Wouter Wolters voted on patch set 1 CR +1 11/18/13, 10:44

  2. Eric Chavaillaz commented on patch set 1 V +1 CR +1 11/18/13, 10:51

    It works, and I can confirm that whitout this addition, the var "$argumentValue" is not passed through the htmlspecialchars function. So this change is necessary!
  3. Mr. Jenkins commented on patch set 1 11/18/13, 10:56

  4. Marc Bastian Heinrichs voted on patch set 1 V +2 CR +2 11/18/13, 13:40

  5. Marc Bastian Heinrichs commented on patch set 1 11/18/13, 13:41

    Cherry Picked This patchset was cherry picked to change: I89794c77ad1bb7bad99517e24ae7345e0803616e
  6. Marc Bastian Heinrichs merged patch set 2 11/18/13, 13:42

  7. Marc Bastian Heinrichs commented on patch set 2 11/18/13, 13:42

    Cherry Picked This patchset was cherry picked to change: I89794c77ad1bb7bad99517e24ae7345e0803616e