Review TYPO3_6-1 Merged

25484[BUGFIX] Check for query failures in admin methods

Francois Suter CR +2 V +2 Easy +10 −6 updated 11/18/13, 11:29

Commit message

In the DatabaseConnection class the two methods admin_get_fields
and admin_get_keys throw a fatal error when a query failure occurs.

This fix introduces two checks that prevent the methods from fataling
and return an empty result on failure.

Review

  • Code review CR +2
    • Francois Suter +2
  • Verified V +2
    • Francois Suter +2

Files 1

Review log 3

  1. Francois Suter commented on patch set 1 V +2 CR +2 11/18/13, 11:23

    Backport from 6.2.
  2. Francois Suter merged patch set 2 11/18/13, 11:23

  3. Francois Suter commented on patch set 2 11/18/13, 11:29

    Ah sorry, backporting to 6.0 is not needed. PDO migration happened in 6.1.