Review main Merged

25491[TASK] Optimization in AbstractViewHelper

Wouter Wolters CR +2 V +2 Easy +2 −1 updated 11/18/13, 23:31

Commit message

Small optimization in AbstractViewHelper to fetch the type
after the check for the default value of the argument.

Review

  • Code review CR +2
    • Thomas Maroschik +2
    • Markus Klein +1
  • Verified V +2
    • Thomas Maroschik +2
    • Markus Klein +1

Issues 1

Files 1

Review log 8

  1. Markus Klein updated the commit message in patch set 1 11/18/13, 21:35

  2. Markus Klein voted on patch set 2 V +1 CR +1 11/18/13, 21:35

  3. Thomas Maroschik voted on patch set 2 V +2 CR +2 11/18/13, 22:58

  4. Thomas Maroschik merged patch set 3 11/18/13, 22:58

  5. Wouter Wolters commented on patch set 3 11/18/13, 23:02

    Cherry Picked This patchset was cherry picked to change: Ie9b68d892f4a20521606709b8fdfba83099c3d70
  6. Wouter Wolters commented on patch set 3 11/18/13, 23:02

    Cherry Picked This patchset was cherry picked to change: Ie9b68d892f4a20521606709b8fdfba83099c3d70
  7. Mr. Jenkins commented on patch set 1 11/18/13, 23:24

  8. Mr. Jenkins commented on patch set 2 11/18/13, 23:31