Review main Merged

25502[BUGFIX] Scheduler extension sql file is invalid

Michiel Roos CR +2 V +2 Easy +2 −2 updated 11/19/13, 14:04

Commit message

On import into MySQL an error is thrown and MySQL
refuses to create the table:

ERROR 1067 (42000) at line 4: Invalid default value for 'uid'

This is due to the fact that a default value is being set
for an auto_increment field.

Review

  • Code review CR +2
    • Markus Klein +2
    • Stefan Froemken +1
  • Verified V +2
    • Markus Klein +2
    • Stefan Froemken +1

Issues 1

Files 1

Review log 10

  1. Mr. Jenkins commented on patch set 1 CR -1 V -1 11/19/13, 11:00

  2. Chris topher updated the commit message in patch set 1 11/19/13, 13:00

  3. Mr. Jenkins commented on patch set 2 11/19/13, 13:15

  4. Markus Klein commented on patch set 2 11/19/13, 13:18

    Please don't repeat the patch in the message here. ;-)
  5. Markus Klein updated the commit message in patch set 2 11/19/13, 13:19

  6. Markus Klein voted on patch set 3 V +1 CR +1 11/19/13, 13:19

  7. Mr. Jenkins commented on patch set 3 11/19/13, 13:33

  8. Stefan Froemken voted on patch set 3 V +1 CR +1 11/19/13, 13:48

  9. Markus Klein voted on patch set 3 V +2 CR +2 11/19/13, 14:04

  10. Markus Klein merged patch set 4 11/19/13, 14:04