Review main Abandoned

25509[BUGFIX] Table cache_imagesizes is defined twice

Michiel Roos CR 0 V 0 Easy +0 −14 updated 11/19/13, 19:28

Commit message

The table cache_imagesizes is defined in two files:
t3lib/stddb/tables.sql
typo3/sysext/cms/ext_tables.sql

This is the case for the 4.5 branch as well as the 4.7 branch.
It has been cleaned up in 6.x.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 8

  1. Markus Klein updated the commit message in patch set 1 11/19/13, 15:34

  2. Markus Klein voted on patch set 2 V +1 CR +1 11/19/13, 15:36

  3. Mr. Jenkins commented on patch set 1 CR -1 V -1 11/19/13, 15:36

  4. Mr. Jenkins commented on patch set 2 11/19/13, 15:46

  5. Wouter Wolters commented on patch set 2 CR -2 11/19/13, 19:17

    This will not work, how can this be tested if the file doesn't even exists in the master branch...
  6. Markus Klein commented on patch set 2 V 0 CR 0 11/19/13, 19:21

    Oh wrong branch, thx for looking. (I applied it manually on 4-5)
  7. Wouter Wolters commented on patch set 2 11/19/13, 19:22

    Will redo for 4.7 and afterwards 4.5
  8. Wouter Wolters abandoned the change 11/19/13, 19:28

    Wrong branch 4.7 is again under review.