25512[BUGFIX] Allow to render the same TS object twice
Commit message
Review
-
Code review CR +2
- Andreas Wolf +2
- Stefan Neufeind +1
- Stefano Kowalke +1
-
Verified V +2
- Andreas Wolf +2
- Stefan Neufeind +1
Issues 2
Files 2
Review log 25
-
Mr. Jenkins commented on patch set 1 11/19/13, 18:04
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12182/ : SUCCESS -
Markus Klein rebased onto patch set 1 12/02/13, 11:19
-
Markus Klein updated the commit message in patch set 2 12/02/13, 11:20
-
Mr. Jenkins commented on patch set 2 12/02/13, 11:34
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12437/ : SUCCESS -
Mr. Jenkins commented on patch set 3 12/02/13, 11:37
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12438/ : SUCCESS -
Markus Klein updated the commit message in patch set 3 12/12/13, 01:43
-
Mr. Jenkins commented on patch set 4 12/12/13, 02:33
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12570/ : SUCCESS -
Markus Klein rebased onto patch set 4 01/23/14, 19:52
-
Mr. Jenkins commented on patch set 5 01/23/14, 20:06
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13187/ : SUCCESS -
Stefan Neufeind voted on patch set 5 V +1 CR +1 02/03/14, 23:50
-
Wouter Wolters commented on patch set 5 02/06/14, 17:12
Cannot reproduce this on current master. Tried with: page.15 = CONTENT page.15 { table=tt_content select { pidInList = 1 } wrap = |<hr> } page.20 < page.15 -
Markus Klein commented on patch set 5 02/06/14, 18:11
Wouter, what is on the page with id 1? It's necessary to have a Insert Records element there. (It's about recursive usage of cObjects) -
Markus Klein commented on patch set 5 02/06/14, 18:22
Ok more precise: It is about the reuse of the SAME CONTENT/RECORDS element. So minimal example for testing the CONTENT element: page { 15 = CONTENT 15 { table=tt_content select { pidInList = 2 } wrap = |<hr> } 20 =< .15 } For testing RECORDS: Just put an Insert Records CE on page 2 and change the =< from above to =. -
Marcin Sągol voted on patch set 5 CR +1 02/06/14, 18:35
-
Stefano Kowalke commented on patch set 5 02/07/14, 08:05
See my inline commentsContentContentObject.php:152I would suggest prefix operator: --$GLOBALS['TSFE']->recordRegister[$originalRec];RecordsContentObject.php:150I would suggest prefix operator: --$GLOBALS['TSFE']->recordRegister[$originalRec]; -
Markus Klein uploaded patch set 6 02/07/14, 08:27
-
Markus Klein commented on patch set 5 02/07/14, 08:28
ContentContentObject.php:152ReplyDoneRecordsContentObject.php:150ReplyDone -
Mr. Jenkins commented on patch set 6 02/07/14, 08:41
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/13778/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/13777/ : SUCCESS -
Stefan Neufeind voted on patch set 6 V +1 CR +1 02/07/14, 09:03
-
Stefano Kowalke voted on patch set 6 CR +1 02/07/14, 09:14
-
Andreas Wolf voted on patch set 6 CR +1 02/08/14, 14:20
-
Andreas Wolf voted on patch set 6 V +2 CR +2 02/09/14, 13:30
-
Andreas Wolf merged patch set 7 02/09/14, 13:30
-
Andreas Wolf commented on patch set 7 02/09/14, 13:50
Cherry Picked This patchset was cherry picked to change: I30750f2dc848521999c3734129439d7f6f90aae1 -
Andreas Wolf commented on patch set 7 02/09/14, 13:51
Cherry Picked This patchset was cherry picked to change: I30750f2dc848521999c3734129439d7f6f90aae1