Review TYPO3_6-0 Merged

25520[BUGFIX] l10n_mode for "pages" table and group fields.

Markus Klein CR +2 V +2 Normal +109 −8 updated 01/08/14, 15:06

Commit message

This patch respects the l10modes for pages, and mergeIfNotBlank for
type "group" fields.

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2
    • Philipp Gampe +1

Files 2

Review log 8

  1. Wouter Wolters commented on patch set 1 V -1 11/19/13, 23:19

    Unit-test do not work at all
  2. Markus Klein commented on patch set 1 11/21/13, 14:36

    @Wouter: this is not the fault of this patch I fear. My fatal error is: Core\Tests\UnitTestCase not found...
  3. Markus Klein commented on patch set 1 11/21/13, 14:40

    sorry my fault, in 6.0 we need: php $PWD/typo3/cli_dispatch.phpsh phpunit -c typo3/sysext/core/Build/UnitTests.xml
  4. Markus Klein uploaded patch set 2 11/22/13, 00:12

  5. Markus Klein commented on patch set 2 V +1 CR +1 11/22/13, 00:14

    Fixed unit tests.
  6. Philipp Gampe commented on patch set 2 V +1 11/26/13, 15:26

    tested with unit tests. I am not into this code, therefore no code review tonight.
  7. Markus Klein voted on patch set 2 V +2 CR +2 01/08/14, 15:06

  8. Markus Klein merged patch set 3 01/08/14, 15:06