Review main Merged

25530[CLEANUP] Fix various spelling mistakes

Michael Stucki CR +2 V +2 Easy +9 −9 updated 11/20/13, 13:41

Commit message

Review

  • Code review CR +2
    • Markus Klein +2
    • Oliver Klee +1
    • Wouter Wolters +1
  • Verified V +2
    • Markus Klein +2
    • Wouter Wolters +1

Issues 1

Files 7

Review log 16

  1. Markus Klein commented on patch set 1 11/20/13, 10:43

    Usually we don't touch the contrib and adodb stuff since this is third party code.
  2. Mr. Jenkins commented on patch set 1 11/20/13, 10:49

  3. Michael Stucki uploaded patch set 2 11/20/13, 11:49

  4. Michael Stucki commented on patch set 2 11/20/13, 11:50

    Correct Markus, I removed them now.
  5. Wouter Wolters commented on patch set 2 V +1 CR +1 11/20/13, 11:53

    Looks good to me!
  6. Oliver Klee voted on patch set 2 CR +1 11/20/13, 11:58

  7. Mr. Jenkins commented on patch set 2 11/20/13, 12:04

  8. Markus Klein voted on patch set 2 V +1 CR +1 11/20/13, 12:20

  9. Markus Klein commented on patch set 2 11/20/13, 12:21

    Feel free to merge yourself Michael, if you think it is ready.
  10. Michael Stucki commented on patch set 2 11/20/13, 12:50

    Still waiting for a +2 :-)
  11. Markus Klein commented on patch set 2 V +2 CR +2 11/20/13, 12:54

    I thought your own +2 should suffice. You already got 2 other AC's votes.
  12. Markus Klein merged patch set 3 11/20/13, 12:54

  13. Michael Stucki commented on patch set 3 11/20/13, 13:23

    Giving myself +2 on an own change? Nono... Anyway, thanks for merging it now, this way it's fine.
  14. Wouter Wolters commented on patch set 3 11/20/13, 13:36

    If you have enough votes but the change is not merged yet, you are allowed to merge it yourself. This is not against the rules;-)
  15. Michael Stucki commented on patch set 3 11/20/13, 13:41

    Yes but I only got +1 on verification. That is not enough.
  16. Michael Stucki commented on patch set 3 11/20/13, 13:41

    Sorry, I'm wrong and you're right. Thanks for the pointer.