25530[CLEANUP] Fix various spelling mistakes
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Oliver Klee +1
- Wouter Wolters +1
-
Verified V +2
- Markus Klein +2
- Wouter Wolters +1
Issues 1
Files 7
- typo3/sysext/core/Classes/Controller/CommandLineController.php+1 −1
- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php+1 −1
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+1 −1
- typo3/sysext/frontend/Tests/Unit/Page/CacheHashCalculatorTest.php+2 −2
- typo3/sysext/install/Classes/Updates/FilePermissionUpdate.php+1 −1
- typo3/sysext/t3editor/res/tsref/tsref.xml+1 −1
- ChangeLog+2 −2
Review log 16
-
Markus Klein commented on patch set 1 11/20/13, 10:43
Usually we don't touch the contrib and adodb stuff since this is third party code. -
Mr. Jenkins commented on patch set 1 11/20/13, 10:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12202/ : SUCCESS -
Michael Stucki uploaded patch set 2 11/20/13, 11:49
-
Michael Stucki commented on patch set 2 11/20/13, 11:50
Correct Markus, I removed them now. -
Wouter Wolters commented on patch set 2 V +1 CR +1 11/20/13, 11:53
Looks good to me! -
Oliver Klee voted on patch set 2 CR +1 11/20/13, 11:58
-
Mr. Jenkins commented on patch set 2 11/20/13, 12:04
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12207/ : SUCCESS -
Markus Klein voted on patch set 2 V +1 CR +1 11/20/13, 12:20
-
Markus Klein commented on patch set 2 11/20/13, 12:21
Feel free to merge yourself Michael, if you think it is ready. -
Michael Stucki commented on patch set 2 11/20/13, 12:50
Still waiting for a +2 :-) -
Markus Klein commented on patch set 2 V +2 CR +2 11/20/13, 12:54
I thought your own +2 should suffice. You already got 2 other AC's votes. -
Markus Klein merged patch set 3 11/20/13, 12:54
-
Michael Stucki commented on patch set 3 11/20/13, 13:23
Giving myself +2 on an own change? Nono... Anyway, thanks for merging it now, this way it's fine. -
Wouter Wolters commented on patch set 3 11/20/13, 13:36
If you have enough votes but the change is not merged yet, you are allowed to merge it yourself. This is not against the rules;-) -
Michael Stucki commented on patch set 3 11/20/13, 13:41
Yes but I only got +1 on verification. That is not enough. -
Michael Stucki commented on patch set 3 11/20/13, 13:41
Sorry, I'm wrong and you're right. Thanks for the pointer.