25634[TASK] Installer: textarea for [FE][defaultTypoScript_setup]
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Wouter Wolters +1
- Philipp Gampe +1
-
Verified V +2
- Christian Kuhn +2
- Philipp Gampe +1
Issues 1
Files 1
Review log 6
-
Mr. Jenkins commented on patch set 1 11/22/13, 11:09
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12265/ : SUCCESS -
Wouter Wolters voted on patch set 1 CR +1 11/22/13, 17:49
-
Philipp Gampe voted on patch set 1 V +1 CR +1 11/22/13, 21:49
-
Markus Klein commented on patch set 1 11/23/13, 20:17
I hope you read my last comment on forge. This might cause problems with extensions. -
Christian Kuhn commented on patch set 1 V +2 CR +2 12/01/13, 11:24
This patch is ok now: new install tool does not load ext_localconf / ext_tables of arbitrary extensions, so even if some ext_localconf of some extension calls \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addTypoScriptSetup('foo = BAR'); or similar, then this will NOT be show in this textarea field :) Tried this patch, works fine for me. -
Christian Kuhn merged patch set 2 12/01/13, 11:24