Review main Merged

25655[BUGFIX] Adjust css in new content element wizard

Nicole Hummel CR +2 V +2 Normal +38 −18 updated 01/30/14, 19:02

Commit message

The rendering of the plugin menu gets messed up if a plugin hasn't any
description. This patch clears floating for every list item to ensure
it is displayed on the left side.

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Wouter Wolters +1
    • Marcin Sągol +1
    • Stefan Froemken +1
  • Verified V +2
    • Steffen Ritter +2
    • Stefan Froemken +1

Issues 1

Files 2

Review log 11

  1. Mr. Jenkins commented on patch set 1 11/23/13, 02:29

  2. Stefan Neufeind commented on patch set 1 V -1 11/24/13, 00:42

    Does not fully seem to solve the problem for me. Without a description the icon "overlaps" the height of the <li>. I'll email you a screenshot.
  3. Ernesto Baschny commented on patch set 1 01/30/14, 13:41

    Benni Kott is working on this one and will push a change soon!
  4. Benjamin Kott uploaded patch set 2 01/30/14, 14:17

  5. Wouter Wolters voted on patch set 2 CR +1 01/30/14, 14:21

  6. Marcin Sągol voted on patch set 2 CR +1 01/30/14, 14:28

  7. Stefan Froemken commented on patch set 2 V +1 CR +1 01/30/14, 14:46

    The bottom line is now correct and does not go through the plugin icon.
  8. Steffen Ritter voted on patch set 2 CR +2 01/30/14, 16:12

  9. Steffen Ritter voted on patch set 2 V +2 01/30/14, 16:16

  10. Steffen Ritter merged patch set 3 01/30/14, 16:16

  11. Mr. Jenkins commented on patch set 2 01/30/14, 19:02