Review main Merged

25662[TASK] Remove unused code in PageLayoutView.php

Bernhard Kraft CR +2 V +2 Easy +2 −23 updated 03/01/15, 19:45

Commit message

Changing the backend view to use grid elements caused an ancient
piece of code in PageLayoutView.php to be never executed. In fact
an if statement in PageLayoutController.php always evaluates to
"FALSE" which lets the code in PageLayoutView.php never get
executed.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Benni Mack +2
    • Frederic Gaus +1
    • Jo Hasenau +1
    • Oliver Klee +1
  • Verified V +2
    • Christian Kuhn +2
    • Benni Mack +1

Issues 1

Files 2

Review log 40

Show 15 earlier messages
  1. Mr. Jenkins commented on patch set 1 11/23/13, 12:53

  2. Markus Klein commented on patch set 1 11/23/13, 20:23

    Very nice. I'll review in detail later.
    Maybe just 6.2?
  3. Markus Klein updated the commit message in patch set 1 01/16/14, 23:15

  4. Markus Klein uploaded patch set 3 01/16/14, 23:24

  5. Markus Klein uploaded patch set 4 01/16/14, 23:30

  6. Markus Klein uploaded patch set 5 01/16/14, 23:31

  7. Markus Klein commented on patch set 5 01/16/14, 23:34

    I took it even one step further and removed all settings which are obsolete now since the 'single' view is not available anymore.
  8. Mr. Jenkins commented on patch set 2 01/16/14, 23:44

  9. Mr. Jenkins commented on patch set 3 01/16/14, 23:44

  10. Mr. Jenkins commented on patch set 4 01/16/14, 23:57

  11. Mr. Jenkins commented on patch set 5 01/16/14, 23:57

  12. Markus Klein commented on patch set 5 CR -2 01/17/14, 15:59

  13. Bernhard Kraft commented on patch set 5 02/26/14, 15:06

    I am not really sure but if I remember it correctly the issue you linked to has nothing to do with this one. This one is about the "single column view" which is not available since 4.? ... It is an ancient feature of TYPO 3.x The "function" menu can not even get set to "4" as this option is removed. Let's wait for the result of the discussion you linke to - then take further steps.
  14. Markus Klein commented on patch set 5 02/26/14, 21:32

    Bernhard, it does not make sense to post your opinion here, if the person who should read it firstline, Jo, is not a reviewer here, but only posted in the ticket. I'll post your message there too, so that Jo gets the message.
  15. Frank Nägler commented on patch set 5 09/23/14, 08:10

    Someone is working on this patch? #old?
  1. Bernhard Kraft commented on patch set 1 09/23/14, 12:04

    I didn't investigates about Markus further patch sets but my original patch set 1 is still valid. Just checked that. If you take a look at "https://git.typo3.org/Packages/TYPO3.CMS.git/blob/HEAD:/typo3/sysext/backend/Classes/Controller/PageLayoutController.php#l958"; You see an if condition which never will be TRUE. With "never TRUE" I don't mean in regard to any settings or whatsoever but rather because (!$variable === 4) will never become TRUE. !$variable will either evaluate to TRUE or FALSE which will never equal 4 in value AND type. So the reason is rather a syntax one. Since this code is in there from 4.x on and noone ever objected I assumed it is irrelevant. I also tried to make this condition TRUE to see what happen. The result was a broken 3.8 style single column mode view. So this patch is still valid - but I can't say that for Markus's patch sets ...
  2. Bernhard Kraft commented on patch set 5 09/23/14, 12:12

    The last patch set from Markus seem to be ok too - but it is quite unreadable because of large pieces of code getting added/removed by indent changing. One would have to download it and check it with "diff -w"
  3. Bernhard Kraft commented on patch set 1 09/23/14, 12:15

    Additionally back then I think I weren't quite in the mood to argue the change. Patch set 1 could have get commited without a wink. Later changes could have done the remaining cleanups. It is the common problem of trying to get the PERFECT patch.
  4. Frank Nägler commented on patch set 5 09/23/14, 13:37

    @Bernhard, thanks for your feedback. I will check the patch later this evening or tomorrow
  5. Markus Klein uploaded patch set 6 09/23/14, 14:29

  6. Markus Klein commented on patch set 6 CR +1 09/23/14, 14:31

    Rebased

    PageLayoutView.php:423

    We only remove this condition. The else part is deleted.
  7. Jo Hasenau commented on patch set 6 CR -1 09/25/14, 10:59

    Actually option 4 was the Grid View, which is now active by default - so the condition was there to check if there is just one column available and no Grid View selected, which should make use of the single column view automatically. IMHO we should not remove that single column view but actually work on it to make it nice and shiny in the new interface, since it will perfectly fit the upcoming stuff related to working with the TYPO3 backend on mobile interfaces.
  8. Felix Kopp commented on patch set 6 09/25/14, 22:31

    Hey guys - set up the single column view and repaired the condition. To me it seems the single column view is broken beyond. Also our current layout works well for only 1x column. I am for removing the broken view that can not be reached :) (Thank you Markus for showing me)
  9. Bernhard Kraft commented on patch set 6 09/26/14, 11:54

    Maybe Jo is right and it was left there by godgiven intention to rework it to a Mobile-Ready responsive page editing module :) I don't know how well gridlayouts works on mobiles and if this is even an target audience. Jo:Do you think it is less work to remove it and implement a fresh small device friendly or heavily modify it?
  10. Benni Mack commented on patch set 6 01/07/15, 19:32

    ping joey...
  11. Jo Hasenau commented on patch set 6 CR +1 01/07/15, 20:19

    Well - since we are reworking the whole backend anyway, there is no need to stick to old structures anymore.
  12. Benni Mack commented on patch set 6 01/08/15, 19:46

    could somebody rebase this one please?
  13. Jan Helke uploaded patch set 7 01/30/15, 18:05

  14. Jan Helke commented on patch set 7 01/30/15, 18:06

    Patch rebased this issue. Now it can be merged again.
  15. Oliver Klee commented on patch set 7 02/01/15, 12:03

    on it.

    PageLayoutView.php:120

    These should be above the corresponding line. No end-line comments anymore.
  16. Oliver Klee uploaded patch set 8 02/01/15, 12:05

  17. Oliver Klee commented on patch set 7 02/01/15, 12:05

    PageLayoutView.php:120 Reply

    Done
  18. Oliver Klee commented on patch set 8 02/01/15, 12:17

    How can we test this?
  19. Jo Hasenau commented on patch set 8 CR +1 02/02/15, 11:34

    Actually you can not really test it, unless you will add option value 4 to the menu again and try if it still has some impact, which it should not have anymore.
  20. Oliver Klee voted on patch set 8 CR +1 02/04/15, 10:27

  21. Frederic Gaus voted on patch set 8 CR +1 02/04/15, 11:16

  22. Benni Mack voted on patch set 8 V +1 03/01/15, 19:06

  23. Benni Mack voted on patch set 8 CR +2 03/01/15, 19:06

  24. Christian Kuhn voted on patch set 8 CR +2 V +2 03/01/15, 19:45

  25. Christian Kuhn merged patch set 8 03/01/15, 19:45