Review main Merged

25668[BUGFIX] Hardcoded "admin" user in Installer template

Markus Klein CR +2 V +2 Easy +1 −1 updated 11/24/13, 17:50

Commit message

The hardcoded username "admin" is removed from the HTML template
since the username can now be freely chosen.

Review

  • Code review CR +2
    • Stefan Neufeind +2
  • Verified V +2
    • Stefan Neufeind +2

Issues 1

Files 1

Review log 5

  1. Mr. Jenkins commented on patch set 1 11/24/13, 08:41

  2. Wouter Wolters updated the commit message in patch set 1 11/24/13, 12:58

  3. Mr. Jenkins commented on patch set 2 11/24/13, 13:14

  4. Stefan Neufeind commented on patch set 2 V +2 CR +2 11/24/13, 17:50

    Easy one. Definitely a good choice instead of long fiddling around getting the username there etc. All fine.
  5. Stefan Neufeind merged patch set 3 11/24/13, 17:50