Review main Merged

25714[TASK] Superfluous comparison in InlineElement

Michiel Roos CR +2 V +2 Easy +1 −1 updated 11/28/13, 18:10

Commit message

Fix superfluous comparison against boolean in
InlineElement::renderForeignRecord().

Review

  • Code review CR +2
    • Wouter Wolters +2
  • Verified V +2
    • Wouter Wolters +2

Issues 1

Files 1

Review log 13

  1. Michiel Roos wrote 11/27/13, 19:34

    Topic set to "performance".
  2. Mr. Jenkins commented on patch set 1 11/27/13, 19:55

  3. Markus Klein commented on patch set 1 CR -1 11/27/13, 21:04

    Please don't repeat the patch in the commit message.
  4. Markus Klein updated the commit message in patch set 1 11/27/13, 21:05

  5. Markus Klein voted on patch set 2 V +1 CR +1 11/27/13, 21:05

  6. Michiel Roos commented on patch set 2 11/27/13, 21:10

    Ok
  7. Mr. Jenkins commented on patch set 2 11/27/13, 21:28

  8. Wouter Wolters voted on patch set 2 V +1 CR +1 11/28/13, 00:00

  9. Michiel Roos voted on patch set 2 V +1 CR +1 11/28/13, 05:29

  10. Wouter Wolters updated the commit message in patch set 2 11/28/13, 17:55

  11. Wouter Wolters commented on patch set 3 V +2 CR +2 11/28/13, 17:55

    Only for 6.2
  12. Wouter Wolters merged patch set 4 11/28/13, 17:55

  13. Mr. Jenkins commented on patch set 3 11/28/13, 18:10