Review main Merged

25715[TASK] Simplify returns in ConfigurationManager

Michiel Roos CR +2 V +2 Easy +4 −15 updated 11/29/13, 17:20

Commit message

writeLocalConfiguration() and writeAdditionalConfiguration()
have return statements like:
return $result === FALSE ? FALSE : TRUE;

This can be reduced to:
return $result;

Moreover the return value of canWriteConfiguration()
can be optimized as well.

Review

  • Code review CR +2
    • Philipp Gampe +2
    • Oliver Klee +1
    • Markus Klein +1
    • Michiel Roos +1
  • Verified V +2
    • Philipp Gampe +2
    • Markus Klein +1
    • Michiel Roos +1

Issues 1

Files 1

Review log 12

  1. Mr. Jenkins commented on patch set 1 CR -1 V -1 11/27/13, 20:03

  2. Markus Klein commented on patch set 1 CR -1 11/27/13, 20:53

    See my comments and the patch has an invalid dependency on Gerrit. (your branch was not clean)
    Line exceeds maximum length of 74 characters (length: 80)

    ConfigurationManager.php:332

    even no need to check against TRUE! Simply return $result.
  3. Markus Klein uploaded patch set 2 11/27/13, 21:00

  4. Markus Klein updated the commit message in patch set 2 11/27/13, 21:01

  5. Markus Klein voted on patch set 3 CR +1 11/27/13, 21:02

  6. Michiel Roos voted on patch set 3 V +1 CR +1 11/27/13, 21:09

  7. Mr. Jenkins commented on patch set 3 11/27/13, 21:14

  8. Mr. Jenkins commented on patch set 2 11/27/13, 21:14

  9. Markus Klein voted on patch set 3 V +1 11/28/13, 23:11

  10. Oliver Klee voted on patch set 3 CR +1 11/29/13, 10:27

  11. Philipp Gampe voted on patch set 3 V +2 CR +2 11/29/13, 17:20

  12. Philipp Gampe merged patch set 4 11/29/13, 17:20