25715[TASK] Simplify returns in ConfigurationManager
Commit message
Review
-
Code review CR +2
- Philipp Gampe +2
- Oliver Klee +1
- Markus Klein +1
- Michiel Roos +1
-
Verified V +2
- Philipp Gampe +2
- Markus Klein +1
- Michiel Roos +1
Issues 1
Files 1
Review log 12
-
Mr. Jenkins commented on patch set 1 CR -1 V -1 11/27/13, 20:03
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/12345/ : FAILURE -
Markus Klein commented on patch set 1 CR -1 11/27/13, 20:53
See my comments and the patch has an invalid dependency on Gerrit. (your branch was not clean)Line exceeds maximum length of 74 characters (length: 80)ConfigurationManager.php:332even no need to check against TRUE! Simply return $result. -
Markus Klein uploaded patch set 2 11/27/13, 21:00
-
Markus Klein updated the commit message in patch set 2 11/27/13, 21:01
-
Markus Klein voted on patch set 3 CR +1 11/27/13, 21:02
-
Michiel Roos voted on patch set 3 V +1 CR +1 11/27/13, 21:09
-
Mr. Jenkins commented on patch set 3 11/27/13, 21:14
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12351/ : SUCCESS -
Mr. Jenkins commented on patch set 2 11/27/13, 21:14
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12350/ : SUCCESS -
Markus Klein voted on patch set 3 V +1 11/28/13, 23:11
-
Oliver Klee voted on patch set 3 CR +1 11/29/13, 10:27
-
Philipp Gampe voted on patch set 3 V +2 CR +2 11/29/13, 17:20
-
Philipp Gampe merged patch set 4 11/29/13, 17:20