Review main Abandoned

25734[TASK] Superfluous comparison in ConfigurationManager

Wouter Wolters CR 0 V 0 Easy +2 −2 updated 11/29/13, 10:34

Commit message

Fix superfluous comparison against boolean in:

ConfigurationManager::writeLocalConfiguration
ConfigurationManager::writeAdditionalConfiguration

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 5

  1. Wouter Wolters wrote 11/28/13, 20:23

    Topic set to "performance".
  2. Mr. Jenkins commented on patch set 1 11/28/13, 20:40

  3. Markus Klein voted on patch set 1 V +1 CR +1 11/28/13, 22:43

  4. Jo Hasenau voted on patch set 1 CR +1 11/29/13, 09:54

  5. Wouter Wolters abandoned the change 11/29/13, 10:34

    This can be done better and is already under review here https://review.typo3.org/#/c/25715/ Sorry!