Review main Merged

25735[TASK] Superfluous comparison in RelationHandler

Wouter Wolters CR +2 V +2 Easy +1 −1 updated 12/17/13, 00:45

Commit message

Fix superfluous comparison against boolean in
RelationHandler::readForeignField

Review

  • Code review CR +2
    • Markus Klein +2
    • Jo Hasenau +1
    • Michiel Roos +1
  • Verified V +2
    • Markus Klein +2
    • Michiel Roos +1

Issues 1

Files 1

Review log 7

  1. Wouter Wolters wrote 11/28/13, 20:40

    Topic set to "performance".
  2. Mr. Jenkins commented on patch set 1 11/28/13, 20:40

  3. Markus Klein commented on patch set 1 V +1 CR +1 11/28/13, 22:45

    I'm pretty sure we've a patch pending changing exactly this too, but I can't find it atm.
  4. Jo Hasenau voted on patch set 1 CR +1 11/29/13, 09:53

  5. Michiel Roos voted on patch set 1 V +1 CR +1 12/17/13, 00:17

  6. Markus Klein voted on patch set 1 V +2 CR +2 12/17/13, 00:45

  7. Markus Klein merged patch set 2 12/17/13, 00:45