Review main Merged

25736[TASK] Superfluous comparison in DatabaseRecordList

Wouter Wolters CR +2 V +2 Easy +1 −1 updated 01/07/14, 23:05

Commit message

Fix superfluous comparison against boolean in
DatabaseRecordList::getTable

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Issues 1

Files 1

Review log 9

  1. Wouter Wolters wrote 11/28/13, 20:40

    Topic set to "performance".
  2. Mr. Jenkins commented on patch set 1 11/28/13, 20:56

  3. Markus Klein commented on patch set 1 11/28/13, 22:46

    Just to be sure, cast in here

    DatabaseRecordList.php:262

    (boolean) cast
  4. Michiel Roos uploaded patch set 2 12/18/13, 15:21

  5. Michiel Roos commented on patch set 1 12/18/13, 15:21

    Cast to (boolean) in new patch set.

    DatabaseRecordList.php:262 Reply

    Done
  6. Mr. Jenkins commented on patch set 2 12/18/13, 15:32

  7. Markus Klein voted on patch set 2 V +1 CR +1 12/18/13, 15:41

  8. Wouter Wolters voted on patch set 2 V +2 CR +2 01/07/14, 23:05

  9. Wouter Wolters merged patch set 3 01/07/14, 23:05