Review main Merged

25737[TASK] Superfluous comparison in CronCommand

Wouter Wolters CR +2 V +2 Easy +2 −2 updated 12/06/13, 22:42

Commit message

Fix superfluous comparison against boolean in
CronCommand::dayMatchesCronCommand

Review

  • Code review CR +2
    • Markus Klein +2
    • Xavier Perseguers +1
  • Verified V +2
    • Markus Klein +2
    • Xavier Perseguers +1

Issues 1

Files 1

Review log 10

  1. Wouter Wolters wrote 11/28/13, 20:44

    Topic set to "performance".
  2. Mr. Jenkins commented on patch set 1 11/28/13, 20:58

  3. Markus Klein commented on patch set 1 11/28/13, 22:48

    CronCommand.php:175

    CGL: typecast: no space
  4. Xavier Perseguers uploaded patch set 2 12/06/13, 22:13

  5. Xavier Perseguers uploaded patch set 3 12/06/13, 22:13

  6. Xavier Perseguers voted on patch set 3 V +1 CR +1 12/06/13, 22:14

  7. Markus Klein voted on patch set 3 V +2 CR +2 12/06/13, 22:19

  8. Markus Klein merged patch set 4 12/06/13, 22:19

  9. Mr. Jenkins commented on patch set 2 12/06/13, 22:31

  10. Mr. Jenkins commented on patch set 3 12/06/13, 22:42