Review main Merged

25739[TASK] Superfluous comparison in OpendocsController

Wouter Wolters CR +2 V +2 Easy +1 −1 updated 12/17/13, 00:46

Commit message

Fix superfluous comparison against boolean in
OpendocsController::checkAccess

Review

  • Code review CR +2
    • Markus Klein +2
    • Jo Hasenau +1
    • Michiel Roos +1
  • Verified V +2
    • Markus Klein +2
    • Michiel Roos +1

Issues 1

Files 1

Review log 7

  1. Wouter Wolters wrote 11/28/13, 20:58

    Topic set to "performance".
  2. Mr. Jenkins commented on patch set 1 11/28/13, 21:10

  3. Markus Klein voted on patch set 1 V +1 CR +1 11/28/13, 22:49

  4. Jo Hasenau voted on patch set 1 CR +1 11/29/13, 09:51

  5. Michiel Roos voted on patch set 1 V +1 CR +1 12/17/13, 00:19

  6. Markus Klein voted on patch set 1 V +2 CR +2 12/17/13, 00:46

  7. Markus Klein merged patch set 2 12/17/13, 00:46