Review main Merged

25741[TASK] Superfluous comparison in Language

Wouter Wolters CR +2 V +2 Easy +2 −2 updated 12/17/13, 00:45

Commit message

Fix superfluous comparison against boolean in
Laguage::getLanguages

Review

  • Code review CR +2
    • Markus Klein +2
    • Michiel Roos +1
    • Xavier Perseguers +1
  • Verified V +2
    • Markus Klein +2
    • Michiel Roos +1

Issues 1

Files 1

Review log 11

  1. Mr. Jenkins commented on patch set 1 11/28/13, 21:23

  2. Markus Klein commented on patch set 1 11/28/13, 22:50

    Language.php:133

    (boolean) cast please to be sure
  3. Xavier Perseguers uploaded patch set 2 12/06/13, 21:58

  4. Xavier Perseguers voted on patch set 2 CR +1 12/06/13, 21:59

  5. Mr. Jenkins commented on patch set 2 12/06/13, 22:12

  6. Markus Klein voted on patch set 2 CR +1 12/06/13, 22:14

  7. Markus Klein voted on patch set 2 V +1 12/06/13, 22:16

  8. Markus Klein commented on patch set 2 12/06/13, 22:17

    Verified this with a little test script.
  9. Michiel Roos voted on patch set 2 V +1 CR +1 12/17/13, 00:14

  10. Markus Klein voted on patch set 2 V +2 CR +2 12/17/13, 00:45

  11. Markus Klein merged patch set 3 12/17/13, 00:45