Review main Merged

25770[BUGFIX] No double htmlspecialchars for filemount select

Alexander Stehlik CR +2 V +2 Easy +2 −2 updated 12/13/13, 08:36

Commit message

Since the labels and values of select items are run through
htmlspecialchars by the FormEngine there is no need to use
htmlspecialchars in the renderTceformsSelectDropdown() method which
generates the select items for the filemount Backend form.

The current code will htmlencode the select value twice which results
in a htmlencoded value in the database which causes problems with
directory names that contain special characters.

Review

  • Code review CR +2
    • Markus Klein +2
    • Oliver Klee +1
    • Helmut Hummel +1
  • Verified V +2
    • Markus Klein +2
    • Helmut Hummel +1

Issues 1

Files 1

Review log 6

  1. Mr. Jenkins commented on patch set 1 11/30/13, 00:17

  2. Helmut Hummel voted on patch set 1 V +1 CR +1 12/12/13, 20:56

  3. Oliver Klee voted on patch set 1 CR +1 12/12/13, 21:12

  4. Markus Klein voted on patch set 1 V +2 CR +2 12/13/13, 08:35

  5. Markus Klein merged patch set 2 12/13/13, 08:35

  6. Markus Klein commented on patch set 2 12/13/13, 08:36

    Cherry Picked This patchset was cherry picked to change: I7ec8262f6c3d20879cde0679636a6a8e5c1d19cd