Review main Abandoned

25788[BUGFIX] Fluid TemplateParser ignores settings for {ns=Tx_..} syntax

Claus Due CR 0 V 0 Easy +9 −8 updated 06/11/14, 12:18

Commit message

The TemplateParser has been given a way to read XML namespace
declarations from templates instead of the old curly braces way,
but a check for a predefined PHP namespace in $this->settings
is only being used in case of XML namespace declarations.

This change makes TemplateParser use predefined PHP namespaces
from $this->settings for both types of declarations.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 4

  1. Mr. Jenkins commented on patch set 1 11/30/13, 13:14

  2. Wouter Wolters voted on patch set 1 CR +1 12/03/13, 18:48

  3. Marc Bastian Heinrichs commented on patch set 1 CR -1 04/03/14, 09:36

    It is the intended behaviour, that the setting is a replacement for the xml only. See change I4d184ee81677c59583bdc7f6f19375155b60efe8 and Fluid Requests http://forge.typo3.org/issues/4472 http://forge.typo3.org/issues/35766
  4. Claus Due abandoned the change 06/11/14, 12:18

    No objection from me then :)