25811[TASK] Add editing of file metadata to ClickMenu
Commit message
Review
-
Code review CR +2
- Steffen Ritter +2
- Stefan Neufeind +1
- Steffen Müller +1
-
Verified V +2
- Steffen Ritter +2
- Stefan Neufeind +1
- Steffen Müller +1
Issues 1
Files 3
Review log 14
-
Mr. Jenkins commented on patch set 1 CR -1 V -1 11/30/13, 19:13
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/12402/ : FAILURE -
Steffen Ritter uploaded patch set 2 11/30/13, 20:22
-
Mr. Jenkins commented on patch set 2 11/30/13, 20:35
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12404/ : SUCCESS -
Steffen Müller commented on patch set 2 11/30/13, 21:07
Works, but causes another issue. Two items with the same name "edit": http://forge.typo3.org/attachments/25628/edit-file.png -
Philipp Gampe voted on patch set 2 V +1 CR +1 11/30/13, 21:47
-
Stefan Neufeind commented on patch set 2 V +1 CR -1 12/01/13, 12:10
Technically correct, but having "Edit" twice in the menu doesn't make much sense to the user. See forge for a screenshot. Imho the first edit (editing the metadata) is the regular handling we have: Edit the "record" you clicked on (here: the metadata). The second button "edit what this record references to" is imho the one that's "out of line". Maybe name that "Edit content" to make clear this actually opens a texteditor? -
Steffen Müller uploaded patch set 3 12/01/13, 14:03
-
Steffen Müller uploaded patch set 4 12/01/13, 14:06
-
Steffen Müller commented on patch set 4 V +1 CR +1 12/01/13, 14:07
Added a new label "Edit content" and assigned it to the corresponding items. -
Mr. Jenkins commented on patch set 3 12/01/13, 14:18
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12415/ : SUCCESS -
Mr. Jenkins commented on patch set 4 12/01/13, 14:22
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12416/ : SUCCESS -
Stefan Neufeind voted on patch set 4 V +1 CR +1 12/01/13, 16:25
-
Steffen Ritter voted on patch set 4 V +2 CR +2 12/07/13, 08:50
-
Steffen Ritter merged patch set 5 12/07/13, 08:50