Review main Merged

25811[TASK] Add editing of file metadata to ClickMenu

Steffen Ritter CR +2 V +2 Easy +9 −2 updated 12/07/13, 08:50

Commit message

The Context-Menu of files misses the editing pen allowing
to directly edit the metadata of the file. Currently it
only shows the edit-content possibility in case it is a
text file.

This patch adds the missing option.

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Stefan Neufeind +1
    • Steffen Müller +1
  • Verified V +2
    • Steffen Ritter +2
    • Stefan Neufeind +1
    • Steffen Müller +1

Issues 1

Files 3

Review log 14

  1. Mr. Jenkins commented on patch set 1 CR -1 V -1 11/30/13, 19:13

  2. Steffen Ritter uploaded patch set 2 11/30/13, 20:22

  3. Mr. Jenkins commented on patch set 2 11/30/13, 20:35

  4. Steffen Müller commented on patch set 2 11/30/13, 21:07

    Works, but causes another issue. Two items with the same name "edit": http://forge.typo3.org/attachments/25628/edit-file.png
  5. Philipp Gampe voted on patch set 2 V +1 CR +1 11/30/13, 21:47

  6. Stefan Neufeind commented on patch set 2 V +1 CR -1 12/01/13, 12:10

    Technically correct, but having "Edit" twice in the menu doesn't make much sense to the user. See forge for a screenshot. Imho the first edit (editing the metadata) is the regular handling we have: Edit the "record" you clicked on (here: the metadata). The second button "edit what this record references to" is imho the one that's "out of line". Maybe name that "Edit content" to make clear this actually opens a texteditor?
  7. Steffen Müller uploaded patch set 3 12/01/13, 14:03

  8. Steffen Müller uploaded patch set 4 12/01/13, 14:06

  9. Steffen Müller commented on patch set 4 V +1 CR +1 12/01/13, 14:07

    Added a new label "Edit content" and assigned it to the corresponding items.
  10. Mr. Jenkins commented on patch set 3 12/01/13, 14:18

  11. Mr. Jenkins commented on patch set 4 12/01/13, 14:22

  12. Stefan Neufeind voted on patch set 4 V +1 CR +1 12/01/13, 16:25

  13. Steffen Ritter voted on patch set 4 V +2 CR +2 12/07/13, 08:50

  14. Steffen Ritter merged patch set 5 12/07/13, 08:50