25814[BUGFIX] ClassAliasMap, Tx_ VH namespace and closing tag throws Exception
Commit message
Review
-
Code review CR +2
- Helmut Hummel +2
-
Verified V +2
- Helmut Hummel +2
Files 1
Review log 28
Show 3 earlier messages
-
Mr. Jenkins commented on patch set 1 11/30/13, 21:31
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12405/ : SUCCESS -
Claus Due uploaded patch set 2 11/30/13, 22:52
-
Claus Due commented on patch set 2 11/30/13, 22:53
Patch set 2: instead of early returning $realClassName, $name is now set to the value before being returned - to be more consistent with other code in the same class.
-
Mr. Jenkins commented on patch set 2 11/30/13, 23:05
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12408/ : SUCCESS -
Claus Due uploaded patch set 3 12/01/13, 13:09
-
Claus Due commented on patch set 3 12/01/13, 13:10
Updated commit message with clear description to reproduce and steps taken to solve. -
Mr. Jenkins commented on patch set 3 12/01/13, 13:23
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12412/ : SUCCESS -
Claus Due uploaded patch set 4 12/02/13, 21:45
-
Claus Due uploaded patch set 5 12/02/13, 21:46
-
Claus Due uploaded patch set 6 12/02/13, 21:50
-
Claus Due rebased onto patch set 6 12/02/13, 21:58
-
Mr. Jenkins commented on patch set 4 12/02/13, 21:58
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12455/ : SUCCESS -
Mr. Jenkins commented on patch set 5 12/02/13, 21:59
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12456/ : SUCCESS -
Mr. Jenkins commented on patch set 6 12/02/13, 22:12
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12457/ : SUCCESS -
Mr. Jenkins commented on patch set 7 12/02/13, 22:14
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12458/ : SUCCESS -
Ludwig Rafelsberger commented on patch set 7 CR +1 12/02/13, 22:33
Reconstructed the problem as described. The patch clearly solves that error for me. I didn't further test the system: lacking experience and infrastructure ;-(… -
Georg Ringer voted on patch set 7 V +1 CR +1 12/03/13, 05:06
-
Wouter Wolters voted on patch set 7 CR +1 12/03/13, 18:31
-
Danilo Bürger commented on patch set 7 V +1 CR +1 12/03/13, 21:23
Reproduced on 6.1.5 / 6.1.6, commit fixes it -
Helmut Hummel commented on patch set 7 CR +1 12/04/13, 17:50
could be merged in master now if super important, but no backports until merge freeze is overshould also go into 6.0 -
Claus Due commented on patch set 7 12/04/13, 17:52
@Helmut I would -greatly- appreciate merging to master. Our CI setup and further namespace migrations in fx EXT:flux depend on it. We can certainly live without the patch on 6.1 for a while still :) -
Helmut Hummel commented on patch set 7 12/04/13, 18:24
@Claus: you take care of the backports (also 6.0) once the merge freeze is over and I will merge it in master. Deal? -
Claus Due commented on patch set 7 12/04/13, 18:41
@Helmut Deal - I've made a calendar entry with alert so I remember it. And thanks! :) -
Claus Due commented on patch set 7 12/04/13, 18:42
Ah, also 6.0 - will update commit with Releases: -
Claus Due uploaded patch set 8 12/04/13, 18:42
-
Mr. Jenkins commented on patch set 8 12/04/13, 18:53
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12470/ : SUCCESS -
Helmut Hummel commented on patch set 8 V +2 CR +2 12/04/13, 18:54
last patch set only updated commit message. votes for ps before count -
Helmut Hummel merged patch set 9 12/04/13, 18:54