2585[FEATURE] expandList for stdWrap
Commit message
Review
-
Code review CR +2
- Xavier Perseguers +2
-
Verified V +2
- Xavier Perseguers +2
Issues 1
Files 1
Review log 38
Show 13 earlier messages
-
Xavier Perseguers merged patch set 1 08/02/11, 13:51
-
Björn Pedersen commented on patch set 1 08/02/11, 13:51
Looks good to me, but someone else must approve -
Stefan Neufeind commented on patch set 1 08/02/11, 13:51
Looks good to me, but someone else must approve -
Stefan Neufeind commented on patch set 1 V 0 08/02/11, 13:51
works. Easy to test: page.5 = TEXT page.5.value = 1,3,5-7,10 page.5.expandList = 1 -
Stefan Neufeind uploaded patch set 2 08/02/11, 13:51
-
Stefan Neufeind commented on patch set 2 08/02/11, 13:51
Verified; Looks good to me, but someone else must approve -
Stefan Neufeind commented on patch set 3 08/02/11, 13:51
Fails; No score removing vote again until we were able to resolve the recent breakage -
Stefan Neufeind commented on patch set 3 08/02/11, 13:51
Hmm, but I ... Anyway. Imho looks okay now. Nice auto-magic by the way :-) Test: page.10 = TEXT page.10,value = 1,2-5,7 page.10.expandList = 1 page.10.expandList.wrap = abc|def Result: abc1,2,3,4,5,7def -
Stefan Neufeind commented on patch set 3 08/02/11, 13:51
From what I found looking at the sources it seems that the case of "expandList = 0" leads to this part of $conf being left out. However for something below "expandList." it's always true and thus always processed if I see correctly. -
Stefan Neufeind commented on patch set 3 08/02/11, 13:51
Somebody from the team please take a final look. Has been verified by several people already. -
Stefan Neufeind commented on patch set 3 08/02/11, 13:51
Verified; Looks good to me, but someone else must approve -
Stefan Neufeind commented on patch set 3 08/02/11, 13:51
page.10.expandList = 0 works as expected but when applying the wrap-line it seems that this confuses the boolean-check. Will look into it. It doesn't seem specific to expandList. -
Stefan Neufeind commented on patch set 3 08/02/11, 13:51
Verified; Looks good to me, but someone else must approve Jo, please create a follow-up issue with your findings.
-
Stefan Neufeind uploaded patch set 3 08/02/11, 13:51
-
Stefan Neufeind commented on patch set 3 08/02/11, 13:51
@Jo: Thank you for the explanations. Definitely right. Sure wrap was not the best example, it was just about testing "anything" from stdWrap works as expected. Just finished my "ride" through the sources of the stdWrap-functionality - and it was an interesting one :-) I can confirm that the expandList-stdWrap works as you describe. -
Xavier Perseguers commented on patch set 3 08/02/11, 13:51
Looks good to me, but someone else must approve About to test it. -
Xavier Perseguers uploaded patch set 4 08/02/11, 13:51
-
Xavier Perseguers commented on patch set 4 V 0 08/02/11, 13:51
by team member; Looks good to me, approved Enough votes. Just fixed the conflict -
Georg Ringer commented on patch set 1 08/02/11, 13:51
which aliases? wanna start the discussion in core mailinglist? IMO other issue -
Philipp Gampe commented on patch set 1 08/02/11, 13:51
Looks good to me, but someone else must approve how about expanding aliases? Move this to another issue? -
Philipp Gampe commented on patch set 3 08/02/11, 13:51
Ok something more reasonable: 10 = TEXT 10.value = 2-4,5,6,3-9,8 10.expandList { if.field = pid if.negate = 1 } This gives: 2,3,4,5,6,3,4,5,6,7,8,9,8 If you replace the 10.expandList with simply 10, you can see that the condition works, but not for expandList. Also note, that I do not have an expandList = 1 any more. -
Philipp Gampe commented on patch set 3 08/02/11, 13:51
Verified; Looks good to me, but someone else must approve Works now with patch from r3356 -
Philipp Gampe commented on patch set 3 08/02/11, 13:51
Fails The following: 10 = TEXT 10.value = 2-4,5,6,3-9,8 10.expandList = 0 10.expandList.wrap = test|lol gives 2,3,4,5,6,3,4,5,6,7,8,9,8 So neither expandList = 0, nor wrap are working (with expandList = 1). -
Jo Hasenau commented on patch set 1 08/02/11, 13:51
Fails; I would prefer that you didn't submit this expandList itself is missing stdWrap properties. So could you please add 'expandList.' to the array of allowed stdWrap properties and add the stdWrap check in the function? I'm currently not able to push anything, so someone else has to do the actual coding. As soon as stdWrap got in, you will get a +1 from my side. -
Jo Hasenau commented on patch set 2 08/02/11, 13:51
Fails; I would prefer that you didn't submit this Thx for taking care of this, but it still doesn't work as expected. Since expandList is defined as boolean, the stdWrap funcitonality has to be applied to the expandList parameter before the actual function can be executed. This way expandList itself will only be set to true, if the stdWrap operation returns it. Could you provide another patch please? -
Jo Hasenau commented on patch set 2 08/02/11, 13:51
Sorry - I have been missing the point completely, since I didn't remember my own comments. // if there is any code one the next level, check if it contains "official" stdWrap functions // if yes, execute them first - will make each function stdWrap aware Due to the registration of both keys "expandList" and "expandList." in the array, there is no need for stdWrap functionality within the function itself, since stdWrap has been applied before. So it will be enough to just add the key with the dot while leaving the function as it has been in patch version 1. Sorry for the confusion -
Jo Hasenau commented on patch set 3 08/02/11, 13:51
Verified; Looks good to me, but someone else must approve 10 = TEXT 10.value = 2-4,5,6,3-9,8 10.expandList { if.field = pid if.negate = 1 } This gives: 2,3,4,5,6,3,4,5,6,7,8,9,8 Of course it does, since if.field = pid gives an empty value. It has to be if.isTrue.field = pid instead, since "if" can't use "field" directly. On the other hand I tested this syntax, and it still doesn't work with ANY of the stdWrapped functions that are of the type boolean (prioriCalc doesn't work with if as well), so the bug is NOT in the new expandList function but somewhere else. So it should be fixed there while this one can still go in. I am currently working on a solution for the boolean functions. -
Jo Hasenau commented on patch set 3 08/02/11, 13:51
No score; No score The problem lies in the stdWrap function which is handling each boolean function twice as soon as it is not set to true. So in the first run the function is ignored if it returns 0, '' or false, but not marked as executed, and in the second run it gets called again, which is why it returns at least 'Array' then, which is not false, 0 or '' We need a separate fix for that, but the implementation of expandList itself is correct so far. -
Jo Hasenau commented on patch set 3 08/02/11, 13:51
Verified; Looks good to me, but someone else must approve -
Jo Hasenau commented on patch set 3 08/02/11, 13:51
No score; No score http://forge.typo3.org/issues/28234 -
Jo Hasenau commented on patch set 3 08/02/11, 13:51
Don't forget this one ... :-) -
Jo Hasenau commented on patch set 3 08/02/11, 13:51
Verified; Looks good to me, but someone else must approve -
Jo Hasenau commented on patch set 3 08/02/11, 13:51
Verified; Looks good to me, but someone else must approve The following: 10 = TEXT 10.value = 2-4,5,6,3-9,8 10.expandList = 0 10.expandList.wrap = test|lol gives 2,3,4,5,6,3,4,5,6,7,8,9,8 So it didn't fail but gave the expected result. stdWrap is applied to expandList and NOT to the result of it! If you want to wrap the result you have to use 10.wrap = Test|lol The stdWrap applied to expandList will ONLY determine IF expandList willbe something else than empty or 0, which will be interpreted as TRUE. So Test0lol will be TRUE and expandList will be executed. @Philipp: Please review your voting -
Jo Hasenau commented on patch set 3 08/02/11, 13:51
No score; No score Actually using a wrap here doesn't make much sense, but something like 10.expandList.field = tx_myext_doexpand could be useful -
Mr. Jenkins commented on patch set 1 08/02/11, 13:51
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/667/ : SUCCESS -
Mr. Jenkins commented on patch set 2 08/02/11, 13:51
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1169/ : SUCCESS -
Mr. Jenkins commented on patch set 3 08/02/11, 13:51
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1175/ : SUCCESS -
Mr. Jenkins commented on patch set 4 08/02/11, 13:51
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1556/ : SUCCESS