Review main Abandoned

25850[BUGFIX] FileListController: Initialise markers even in case of error

Stefan Neufeind CR 0 V 0 Easy +18 −3 updated 01/28/14, 19:05

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 4

  1. Stefan Neufeind commented on patch set 1 12/01/13, 15:20

    Didn't check previous releases yet - but I expect so? Should be checked if this change finds approval, before merge.

    FileListController.php:370

    We don't need a full "filelist". But idea is here to still use the same function to fetch the buttonMarkers as in the regular case

    FileList.php:251

    listURL() checks for $this->folderObject. (Should it maybe work on the local $folderObject given in this function instead?). If we can base this check on $folderObject instead of $this->folderObject we can move this line into the above if-statement. Refresh is initialised empty above. So in case we don't have a folderObject (error, ...), there is simply nothing to refresh.
  2. Mr. Jenkins commented on patch set 1 12/01/13, 15:32

  3. Bernhard Kraft commented on patch set 1 V -1 12/03/13, 17:03

    I get: #1: PHP Catchable Fatal Error: Argument 1 passed to TYPO3\CMS\Filelist\FileList::getButtonsAndOtherMarkers() must be an instance of TYPO3\CMS\Core\Resource\Folder, null given, called in /home/kraftb/src/TYPO3.CMS/typo3/sysext/filelist/Classes/Controller/FileListController.php on line 373 and defined in /home/kraftb/src/TYPO3.CMS/typo3/sysext/filelist/Classes/FileList.php line 211 (More information)
  4. Stefan Neufeind abandoned the change 01/28/14, 19:05

    abandoned in favor of https://review.typo3.org/27102