25851[TASK] Add tool-function to strip PATH_site-part of paths
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Philipp Gampe +1
-
Verified V +2
- Markus Klein +2
- Philipp Gampe +1
Issues 1
Files 41
- typo3/sysext/aboutmodules/Classes/Controller/ModulesController.php+1 −1
- typo3/sysext/backend/Classes/Controller/Wizard/ColorpickerController.php+1 −1
- typo3/sysext/backend/Classes/Controller/NoDocumentsOpenController.php+2 −2
- typo3/sysext/backend/Classes/Controller/ShortcutFrameController.php+1 −1
- typo3/sysext/backend/Classes/Form/FormEngine.php+4 −4
- typo3/sysext/backend/Classes/Module/ModuleLoader.php+1 −1
- typo3/sysext/backend/Classes/Template/DocumentTemplate.php+1 −1
- typo3/sysext/backend/Classes/Toolbar/ShortcutToolbarItem.php+1 −1
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+1 −1
- typo3/sysext/backend/Classes/View/ModuleMenuView.php+1 −1
- typo3/sysext/core/Classes/Database/ReferenceIndex.php+2 −2
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+3 −3
- typo3/sysext/core/Classes/Html/RteHtmlParser.php+3 −3
- typo3/sysext/core/Classes/Localization/Parser/LocallangArrayParser.php+2 −2
- typo3/sysext/core/Classes/Resource/Driver/LocalDriver.php1+1 −1
- typo3/sysext/core/Classes/Resource/ResourceFactory.php+1 −1
- typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php+1 −1
- typo3/sysext/core/Classes/TypoScript/TemplateService.php+1 −1
- typo3/sysext/core/Classes/Utility/DebugUtility.php+1 −1
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+1 −1
Show 21 more files
- typo3/sysext/core/Classes/Utility/GeneralUtility.php5+2 −2
- typo3/sysext/core/Classes/Utility/PathUtility.php4+16 −0
- typo3/sysext/cshmanual/Classes/Controller/HelpModuleController.php+2 −2
- typo3/sysext/dbal/Classes/Database/DatabaseConnection.php+1 −1
- typo3/sysext/extensionmanager/Classes/Utility/FileHandlingUtility.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ResourceViewHelper.php+1 −1
- typo3/sysext/impexp/Classes/Controller/ImportExportController.php+7 −7
- typo3/sysext/impexp/Classes/ImportExport.php+10 −10
- typo3/sysext/indexed_search/Classes/Controller/IndexedPagesController.php+1 −1
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+2 −2
- typo3/sysext/indexed_search/Classes/Controller/SearchFormController.php+2 −2
- typo3/sysext/indexed_search/Classes/Hook/CrawlerHook.php+1 −1
- typo3/sysext/install/Classes/Service/CoreUpdateService.php+2 −2
- typo3/sysext/install/Classes/ViewHelpers/File/RelativePathViewHelper.php+1 −1
- typo3/sysext/lowlevel/Classes/View/DatabaseIntegrityView.php+1 −1
- typo3/sysext/lowlevel/Classes/DoubleFilesCommand.php+1 −1
- typo3/sysext/lowlevel/Classes/RteImagesCommand.php+1 −1
- typo3/sysext/recordlist/Classes/Browser/ElementBrowser.php+1 −1
- typo3/sysext/reports/Classes/Report/Status/ConfigurationStatus.php+1 −1
- typo3/sysext/rtehtmlarea/Classes/Controller/CustomAttributeController.php+1 −1
- typo3/sysext/rtehtmlarea/Classes/SelectImage.php+2 −2
Review log 18
-
Stefan Neufeind commented on patch set 1 12/01/13, 15:59
Please judge on the idea of this patch, naming of the function etc. Currently this patch is only against EXT:core. More would need to be added if this finds consensus. Could somebody maybe give a performance-estimate? Might this make sense? I expect calling a static function is not as expensive as calculating the strlen() over and over again. -
Mr. Jenkins commented on patch set 1 12/01/13, 16:08
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12423/ : SUCCESS -
Markus Klein commented on patch set 1 12/02/13, 11:10
IMO a good thing. At least the functionality is centralized.GeneralUtility.php:1589StripGeneralUtility.php:1595initialize with NULL -
Steffen Ritter commented on patch set 1 CR -1 12/02/13, 11:29
small nitpicksLocalDriver.php:175does not belong to that patchGeneralUtility.php:1594Please in PathUtility -
Helmut Hummel commented on patch set 1 12/02/13, 13:34
GeneralUtility.php:1594ReplyAnd the should have something like "relative path" in it. -
Helmut Hummel commented on patch set 1 CR -1 12/02/13, 13:35
GeneralUtility.php:1594Replymaybe even use PathUtility::getRelativePathTo() ... -
Stefan Neufeind uploaded patch set 2 12/08/13, 15:43
-
Stefan Neufeind commented on patch set 2 12/08/13, 15:49
Moved to PathUtility. Discussed naming/API with Helmut and we agreed that having "another getRelative*"-function in the API is not really the best idea. But we settled on having this as a "cleanup" for now and mark it @internal for now. This was we have the code in a central place, have it easier to search and rework this area int he future, but don't suffer from the burden of another API-addition. Switching to getRelative*, which Helmut proposed, might be a good idea. But that needs some more work and we'll maybe need to review each and every occurence of this function-call in detail. -
Mr. Jenkins commented on patch set 2 12/08/13, 15:57
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12525/ : SUCCESS -
Philipp Gampe voted on patch set 2 CR +1 12/08/13, 16:59
-
Philipp Gampe commented on patch set 2 V +1 12/08/13, 17:03
tested with unit tests -
Markus Klein voted on patch set 2 CR +1 12/18/13, 22:26
-
Markus Klein voted on patch set 2 V +2 CR +2 12/18/13, 22:29
-
Markus Klein merged patch set 3 12/18/13, 22:29
-
Helmut Hummel commented on patch set 3 12/18/13, 22:34
post reviewPathUtility.php:317didn't we agree to mark this method as @internal, to make clear this is not public API (yet)? -
Markus Klein commented on patch set 3 12/18/13, 22:45
PathUtility.php:317ReplySorry, I didn't see that comment. It was not annotated here. Shall I push a followup? -
Helmut Hummel commented on patch set 3 12/18/13, 22:51
PathUtility.php:317Replyno worries. A followup would be awesome, thanks. -
Markus Klein commented on patch set 3 12/19/13, 00:17
PathUtility.php:317ReplyDone in https://review.typo3.org/26486